Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] values for other HK #12

Closed
kwithus opened this issue Aug 19, 2024 · 3 comments · Fixed by #22
Closed

[FEATURE] values for other HK #12

kwithus opened this issue Aug 19, 2024 · 3 comments · Fixed by #22
Assignees
Labels
enhancement New feature or request

Comments

@kwithus
Copy link
Contributor

kwithus commented Aug 19, 2024

Wäre schön, wenn man (optional?) auch weitere HK anzeigen/steuern könnte. Ich habe drei verschiedene Heizkreise.

@LarsK1
Copy link
Owner

LarsK1 commented Aug 19, 2024

Hi @kwithus,
ich schließe aus deinem Diskussionsthema, dass du die zugehörigen Modbus-ID kennst - wenn du mir diese verrätst pflege ich diese gerne mit ein.

@LarsK1 LarsK1 added enhancement New feature or request and removed not verified labels Aug 19, 2024
@kwithus
Copy link
Contributor Author

kwithus commented Aug 19, 2024

Das meiste ergibt sich ja aus der offiziellen Dokumentation, ein paar Adressen habe ich zusätzlich zuordnen können.
Wobei gerade bei den TempFühlern das von Installation zu Installation unterschiedlich sein kann, dh. Das Beste wäre, wenn die Integration Optionen hätte, um auszuwählen welche Adressen abgefragt / beschrieben werden sollten, wobei dabei die 'offiziellen' Bezeichnungen verwendet werden und man dann die Bezeichnungen individuell anpasst.
SC-3_ModBus_Schnittstellenbeschreibung 2.pdf
Solvis Modbus Adressen.pdf

@github-actions github-actions bot added the stale label Sep 19, 2024
@github-actions github-actions bot closed this as completed Oct 3, 2024
@LarsK1 LarsK1 removed the stale label Oct 3, 2024
@LarsK1 LarsK1 reopened this Oct 3, 2024
Repository owner deleted a comment from github-actions bot Oct 3, 2024
Repository owner deleted a comment from github-actions bot Oct 3, 2024
@kwithus
Copy link
Contributor Author

kwithus commented Oct 5, 2024

Well, I managed to add HKR2 and 3 to my installation, and I tried to create a pull request for that by uploading the changed files, however, I havent done a pull request for long time and I am not sure, whether I have done it correctly.
If not, please give me so,e instructions what to do

@LarsK1 LarsK1 linked a pull request Oct 6, 2024 that will close this issue
@LarsK1 LarsK1 closed this as completed in #22 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants