chore: Don't return commitment for OP Keccak256 mode on PUT requests (#147)

* chore: Only return commitment on PUT for OP Generic and Simple commitment modes

* chore: Only return commitment on PUT for OP Generic and Simple commitment modes - update tests

* chore: Only return commitment on PUT for OP Generic and Simple commitment modes

* chore: Only return commitment on PUT for OP Generic and Simple commitment modes- rm error file

Author: ethenotethan

server/server.go

@@ -261,8 +261,10 @@ func (svr *Server) HandlePut(w http.ResponseWriter, r *http.Request) (commitment
 	}
 
 	svr.log.Info(fmt.Sprintf("response commitment: %x\n", responseCommit))
-	// write out encoded commitment
-	svr.WriteResponse(w, responseCommit)
+	// write commitment to resp body if not in OptimismKeccak mode
+	if meta.Mode != commitments.OptimismKeccak {
+		svr.WriteResponse(w, responseCommit)
+	}
 	return meta, nil
 }
 

server/server_test.go

@@ -242,7 +242,7 @@ func TestPutHandler(t *testing.T) {
 				mockRouter.EXPECT().Put(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return([]byte(testCommitStr), nil)
 			},
 			expectedCode:           http.StatusOK,
-			expectedBody:           opKeccakPrefix + testCommitStr,
+			expectedBody:           "",
 			expectError:            false,
 			expectedCommitmentMeta: commitments.CommitmentMeta{Mode: commitments.OptimismKeccak, CertVersion: 0},
 		},
@@ -274,9 +274,13 @@ func TestPutHandler(t *testing.T) {
 				require.NoError(t, err)
 			}
 			require.Equal(t, tt.expectedCode, rec.Code)
-			if !tt.expectError {
+			if !tt.expectError && tt.expectedBody != "" {
 				require.Equal(t, []byte(tt.expectedBody), rec.Body.Bytes())
 			}
+
+			if !tt.expectError && tt.expectedBody == "" {
+				require.Equal(t, []byte(nil), rec.Body.Bytes())
+			}
 			require.Equal(t, tt.expectedCommitmentMeta, meta)
 		})
 	}

store/generated_key/eigenda/eigenda.go

@@ -147,6 +147,6 @@ func (e Store) Verify(key []byte, value []byte) error {
 		return fmt.Errorf("failed to verify commitment: %w", err)
 	}
 
-	// verify DA certificate against on-chain
+	// verify DA certificate against EigenDA's batch metadata that's bridged to Ethereum
 	return e.verifier.VerifyCert(&cert)
 }