Skip to content

Commit 8e5e6f7

Browse files
author
anupsv
committed
changing test name and adding OP issue link
1 parent 10cfd7f commit 8e5e6f7

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

e2e/server_test.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,27 +23,27 @@ func isPanic(err string) bool {
2323
strings.Contains(err, "nil pointer dereference")
2424
}
2525

26-
func TestOptimismClientWithKeccak256CommitmentIntegration(t *testing.T) {
26+
func TestOpClientKeccak256MalformedInputs(t *testing.T) {
2727
if !runIntegrationTests || runTestnetIntegrationTests {
2828
t.Skip("Skipping test as TESTNET env set or INTEGRATION var not set")
2929
}
3030

31-
// nil commitment. Should return an error but currently is not. This needs to be fixed by OP
32-
// t.Run("nil commitment case", func(t *testing.T) {
33-
// var commit op_plasma.CommitmentData
34-
// _, err := daClient.GetInput(ts.Ctx, commit)
35-
// require.Error(t, err)
36-
// assert.True(t, !isPanic(err.Error()))
37-
// })
38-
3931
t.Parallel()
40-
4132
testCfg := e2e.TestConfig(useMemory())
4233
testCfg.UseKeccak256ModeS3 = true
43-
4434
ts, kill := e2e.CreateTestSuite(t, testCfg)
4535
defer kill()
4636

37+
// nil commitment. Should return an error but currently is not. This needs to be fixed by OP
38+
// Ref: https://github.com/ethereum-optimism/optimism/issues/11987
39+
//daClient := op_plasma.NewDAClient(ts.Address(), false, true)
40+
//t.Run("nil commitment case", func(t *testing.T) {
41+
// var commit op_plasma.CommitmentData
42+
// _, err := daClient.GetInput(ts.Ctx, commit)
43+
// require.Error(t, err)
44+
// assert.True(t, !isPanic(err.Error()))
45+
//})
46+
4747
daClientPcFalse := op_plasma.NewDAClient(ts.Address(), false, false)
4848

4949
t.Run("input bad data to SetInput & GetInput", func(t *testing.T) {

0 commit comments

Comments
 (0)