chore(simple_client): Add explicit ServiceUnavailable error type - address PR comment

Author: ethenotethan

server/config.go

@@ -47,11 +47,20 @@ func (cfg *Config) Check() error {
 
 	// provide dummy values to eigenda client config. Since the client won't be called in this
 	// mode it doesn't matter.
-	if cfg.MemstoreEnabled || !cfg.VerifierConfig.VerifyCerts {
+	if cfg.MemstoreEnabled {
 		cfg.EdaClientConfig.SvcManagerAddr = "0x0000000000000000000000000000000000000000"
 		cfg.EdaClientConfig.EthRpcUrl = "http://0.0.0.0:666"
 	}
 
+	if !cfg.MemstoreEnabled {
+		if cfg.EdaClientConfig.SvcManagerAddr == "" {
+			return fmt.Errorf("service manager address is required for communication with EigenDA")
+		}
+		if cfg.EdaClientConfig.EthRpcUrl == "" {
+			return fmt.Errorf("eth prc url is required for communication with EigenDA")
+		}
+	}
+
 	// cert verification is enabled
 	// TODO: move this verification logic to verify/cli.go
 	if cfg.VerifierConfig.VerifyCerts {

server/config_test.go

@@ -90,8 +90,7 @@ func TestConfigVerification(t *testing.T) {
 			require.Error(t, err)
 		})
 
-		t.Run("EigenDAClientFieldsAreDefaultSetWhenCertVerifierDisabled", func(t *testing.T) {
-			// 1 - memstore
+		t.Run("EigenDAClientFieldsAreDefaultSetWhenMemStoreEnabled", func(t *testing.T) {
 			cfg := validCfg()
 			cfg.MemstoreEnabled = true
 			cfg.VerifierConfig.VerifyCerts = false
@@ -102,18 +101,16 @@ func TestConfigVerification(t *testing.T) {
 			require.NoError(t, err)
 			require.True(t, len(cfg.EdaClientConfig.EthRpcUrl) > 1)
 			require.True(t, len(cfg.EdaClientConfig.SvcManagerAddr) > 1)
+		})
 
-			// 2 - cert verification disabled
-			cfg = validCfg()
+		t.Run("FailWhenEigenDAClientFieldsAreUnsetAndMemStoreDisabled", func(t *testing.T) {
+			cfg := validCfg()
 			cfg.MemstoreEnabled = false
-			cfg.VerifierConfig.VerifyCerts = false
 			cfg.VerifierConfig.RPCURL = ""
 			cfg.VerifierConfig.SvcManagerAddr = ""
 
-			err = cfg.Check()
-			require.NoError(t, err)
-			require.True(t, len(cfg.EdaClientConfig.EthRpcUrl) > 1)
-			require.True(t, len(cfg.EdaClientConfig.SvcManagerAddr) > 1)
+			err := cfg.Check()
+			require.Error(t, err)
 		})
 	})