From e5b83adcc67d79bd13a88b82258333243ef76bce Mon Sep 17 00:00:00 2001 From: Ethen Pociask Date: Tue, 3 Dec 2024 19:10:12 +0700 Subject: [PATCH] fix: Disable svc manager address & eth rpc as mandatory --- client/simple.go | 2 +- flags/eigendaflags/cli.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/simple.go b/client/simple.go index 6079da3..93dbd3f 100644 --- a/client/simple.go +++ b/client/simple.go @@ -15,7 +15,7 @@ type Config struct { // SimpleCommitmentClient implements a simple client for the eigenda-proxy // that can put/get simple commitment data and query the health endpoint. -// It is meant to be used by arbitrum nitro integrations. +// Currently it is meant to be used by Arbitrum nitro integrations but can be extended to others in the future. // Optimism has its own client: https://github.com/ethereum-optimism/optimism/blob/develop/op-alt-da/daclient.go // so clients wanting to send op commitment mode data should use that client. type SimpleCommitmentClient struct { diff --git a/flags/eigendaflags/cli.go b/flags/eigendaflags/cli.go index f186834..060f555 100644 --- a/flags/eigendaflags/cli.go +++ b/flags/eigendaflags/cli.go @@ -144,14 +144,14 @@ func CLIFlags(envPrefix, category string) []cli.Flag { Usage: "URL of the Ethereum RPC endpoint. Needed to confirm blobs landed onchain.", EnvVars: []string{withEnvPrefix(envPrefix, "ETH_RPC")}, Category: category, - Required: true, + Required: false, }, &cli.StringFlag{ Name: SvcManagerAddrFlagName, Usage: "Address of the EigenDAServiceManager contract. Required to confirm blobs landed onchain. See https://github.com/Layr-Labs/eigenlayer-middleware/?tab=readme-ov-file#current-mainnet-deployment", EnvVars: []string{withEnvPrefix(envPrefix, "SERVICE_MANAGER_ADDR")}, Category: category, - Required: true, + Required: false, }, // Flags that are proxy specific, and not used by the eigenda-client // TODO: should we move this to a more specific category, like EIGENDA_STORE?