Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support redis backend for memstore #72

Closed
EthenNotEthan opened this issue Jul 31, 2024 · 3 comments
Closed

Support redis backend for memstore #72

EthenNotEthan opened this issue Jul 31, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@EthenNotEthan
Copy link
Collaborator

Using redis would allow us to ensure that data isn't deleted when the instance is torn down. This will be especially useful for debugging / feedback cycles when engineering against a live rollup. Otherwise we'll have to reinstate the entire rollup if the proxy instance is terminated.

@EthenNotEthan EthenNotEthan added enhancement New feature or request good first issue Good for newcomers labels Aug 22, 2024
@samlaf
Copy link
Collaborator

samlaf commented Sep 6, 2024

@epociask this was my point. You added redis as a cache layer. But here's it's suggesting to add it as a replacement for memstore right? Why this separation between backends that store with Keys vs those that don't?

@EthenNotEthan
Copy link
Collaborator Author

@samlaf this was an old issue filed before we introduced these newer abstractions. Technically we can achieve the same effect now by using a cache target with S3 for a memstore backend.

@EthenNotEthan
Copy link
Collaborator Author

closed by #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants