Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Rename api.clients.eigenda_client.IEigenDAClient.GetBlob as GetPayload #1076

Open
bxue-l2 opened this issue Jan 7, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@bxue-l2
Copy link
Contributor

bxue-l2 commented Jan 7, 2025

Use case and current behavior

Similarly for PutBlob
Currently, the name is misleading. Because blob contains other metadata prepended to the user data.

In more details, eigenda_client does the following

  1. rollup data
  2. create a blob header containing rollup data length
  3. do a codec on the (header || rollup date) by padding an empty byte for every 31 bytes.
  4. to commit the polynomial, we have to pad the above data to next power of 2. Because if we want to open a point later, so it has to be the next power of 2. For most fraud proof use case, we treat the the processed data above as evaluation of a polynomial (if the data is not fault provable, it restriction can be removed)

Because of the step 2, GetBlob is incorrect, similarly PutBlob in incorrect.

Enhancement

Change the interface into PutUserData, GetUserData

Solution proposal

as above

Additional Information

No response

@bxue-l2 bxue-l2 added the enhancement New feature or request label Jan 7, 2025
@samlaf
Copy link
Contributor

samlaf commented Jan 7, 2025

+1. Either RollupData or RollupBlob or anything else to differentiate it from "Blobs" that are used inside the network.

@bxue-l2
Copy link
Contributor Author

bxue-l2 commented Jan 7, 2025

EigenDA can servers non-rollup users, making it more generic.

or clientData

@samlaf samlaf changed the title [Enhancement]: Rename api.clients.eigenda_client.IEigenDAClient.GetBlob as GetUserData [Enhancement]: Rename api.clients.eigenda_client.IEigenDAClient.GetBlob as GetPayload Jan 10, 2025
@litt3
Copy link
Contributor

litt3 commented Jan 17, 2025

@bxue-l2 Is the proposal to make this change to the v1 client?

For v2, it will be implemented as GetPayload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants