Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger BTC app does not work via U2F on most browsers #112

Open
destrys opened this issue Apr 25, 2019 · 2 comments
Open

Ledger BTC app does not work via U2F on most browsers #112

destrys opened this issue Apr 25, 2019 · 2 comments

Comments

@destrys
Copy link

destrys commented Apr 25, 2019

Observed Behavior

When interacting with the bitcoin app on a Ledger Nano S via a browser with U2F:

  1. The device and application behave correctly as long as you complete the required click actions in a very short amount of time (2-3 seconds).
  2. If you take longer than that, the device appears to behave normally, but upon finishing your interaction, the web application does not respond.
  3. Eventually, (~30 seconds) the web application receives a U2F timeout error.

We observe this behavior with Chrome and Opera, but not with Firefox.

We do not observe any issues when interacting with the Ledger Ethereum App (with hw-transport-u2f)

Because of the last two reasons, this does not appear to be an issue with the browsers, @ledgerhq/hw-app-btc, or hw-transport-u2f.

Reproducible Example

We have provided a bare-bones example app at https://codesandbox.io/s/lp0j17klj9
It is only trying to call getWalletPublicKey() at BIP32 path m/45'/0'/0'

I have also seen this behavior easily reproduced using the ledger-provided wallet-webtool at
https://ledgerhq.github.io/ledger-wallet-webtool/

System

OS: Mac 10.14
Browsers: Chrome 73.0.3683.103, Opera 60.0.3255.59
Ledger Live: 1.7.0
Ledger Nano S: Firmware: 1.5.5 (MCU 1.7)
Ledger Bitcoin App: 1.3.8
@ledgerhq/hw-transport-u2f: 4.54.0
@ledgerhq/hw-btc-app: 4.54.0

Workarounds

We are currently instructing customers to use Firefox as that is the only browser that currently seems to work.

Fast button-clicking is not a viable workaround since you have to complete your interaction before all the necessary information has been displayed on the ledger screen, making it impossible to verify transaction details.

Using hw-transport-webusb has been suggested, but it is still labeled ‘experimental’; our production application requires high security and we are uncomfortable running code so-labeled. Furthermore, hw-transport-webusb has limited browser support (https://caniuse.com/#feat=webusb), which negatively impacts our end-users.

Communications

@btchip has mentioned this is "typically the old buggy behavior", and that recompiling the bitcoin app may be a solution (I have not tried this). Even if this works, our users cannot do this, they can only use applications distributed through Ledger Live. If this is the fix, we’d need Ledger to do it.

@destrys
Copy link
Author

destrys commented May 9, 2019

We noticed that the 1552-u2f-fix-2 branch was merged into the nano secure sdk master branch (LedgerHQ/nanos-secure-sdk#21), nice work. Does this mean we'll be seeing a new version of the the BTC app built with the updated SDK soon?

@nyetwurk
Copy link

Is this related to LedgerHQ/ledgerjs#306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants