Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stax : fix BLE pairing in apps #423

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

sportron-ledger
Copy link
Contributor

@sportron-ledger sportron-ledger commented Sep 12, 2023

Description

Please provide a detailed description of what was done in this PR.
(And mention any links to an issue docs)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

@sportron-ledger sportron-ledger force-pushed the pr-stax-fix-app-ble-pairing branch 2 times, most recently from 6fc88a0 to 4417c9b Compare September 14, 2023 09:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (d5b0435) 69.37% compared to head (9ce677f) 69.33%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   69.37%   69.33%   -0.04%     
==========================================
  Files          11       11              
  Lines         875      874       -1     
==========================================
- Hits          607      606       -1     
  Misses        268      268              
Flag Coverage Δ
unittests 69.33% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib_nbgl/src/nbgl_fonts.c 65.53% <ø> (+0.11%) ⬆️
lib_nbgl/src/nbgl_obj_pool.c 38.15% <ø> (ø)
lib_nbgl/src/nbgl_screen.c 45.18% <ø> (-0.34%) ⬇️
lib_standard_app/base58.c 87.09% <ø> (ø)
lib_standard_app/bip32.c 83.33% <ø> (ø)
lib_standard_app/buffer.c 91.54% <ø> (ø)
lib_standard_app/format.c 96.73% <ø> (ø)
lib_standard_app/parser.c 92.85% <ø> (ø)
lib_standard_app/read.c 100.00% <ø> (ø)
lib_standard_app/varint.c 36.00% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sportron-ledger sportron-ledger merged commit 94e058e into master Sep 14, 2023
160 checks passed
@sportron-ledger sportron-ledger deleted the pr-stax-fix-app-ble-pairing branch September 14, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants