Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't show snap assist box when user tries to snap to edge an untilable window by dragging #387

Closed
amethystgosling163 opened this issue Jan 11, 2025 · 0 comments · Fixed by #389
Closed

don't show snap assist box when user tries to snap to edge an untilable window by dragging #387

amethystgosling163 opened this issue Jan 11, 2025 · 0 comments · Fixed by #389
Labels
bug Something isn't working

Comments

@amethystgosling163
Copy link

Describe the bug
Already described

Demonstration
https://github.com/user-attachments/assets/9b45c6dd-98cd-4de5-8be1-463ef534be83

Steps To Reproduce

  1. Open a window that is untilable.
  2. Drag it to the edge to snap it.

Actual Result
Since the window is untilable, it won't snap to that portion of the screen but the snap assist box/ cue will still appear.

Expected Result
That box/ cue shouldn't appear because the window is actually untilable.

System Info:

  • Distro (incl. version): Ultramarine/ Fedora 40
  • GNOME Shell version: 46
  • Extension version and from where (e. g. EGO, main branch...): 48 (EGO)
  • XOrg/Wayland: Wayland

Journalctl logs

None
@amethystgosling163 amethystgosling163 added the bug Something isn't working label Jan 11, 2025
@amethystgosling163 amethystgosling163 changed the title Don't show snap Assist box when user tries to snap to edge an untilable window by dragging don't show snap Assist box when user tries to snap to edge an untilable window by dragging Jan 11, 2025
@amethystgosling163 amethystgosling163 changed the title don't show snap Assist box when user tries to snap to edge an untilable window by dragging don't show snap assist box when user tries to snap to edge an untilable window by dragging Jan 11, 2025
Leleat pushed a commit that referenced this issue Jan 22, 2025
ignore move op for unresizable and skip_taskbar windows
Loading
Loading status checks…
d3f3f6f 
So far, we've ignored skip-taskbar windows when trying to tile them (in
TilingWindowManager.tile). The reason is that those windows probably shouldn't
be allowed to be tiled, as they are usually stuff like modal dialogs etc. But
at the moment we do show the tile preview for those windows, which gives the
impression that we allow them to be tiled.

I guess, we could allow skip-taskbar windows to be tiled (as long as they are
resizable) but I think there may be more issues with them, e. g. when using
modal dialogs that the parent window may be tiled but the dialog not. So I think
it's better to just ignore them for now. attach-modal-dialogs settings is
relevant to this issue.

Closes #387
@Leleat Leleat mentioned this issue Jan 22, 2025
Merged
Leleat pushed a commit that referenced this issue Feb 3, 2025
@Leleat
ignore move op for unresizable and skip_taskbar windows
Loading
Loading status checks…
d960eed 
So far, we've ignored skip-taskbar windows when trying to tile them (in
TilingWindowManager.tile). The reason is that those windows probably shouldn't
be allowed to be tiled, as they are usually stuff like modal dialogs etc. But
at the moment we do show the tile preview for those windows, which gives the
impression that we allow them to be tiled.

I guess, we could allow skip-taskbar windows to be tiled (as long as they are
resizable) but I think there may be more issues with them, e. g. when using
modal dialogs that the parent window may be tiled but the dialog not. So I think
it's better to just ignore them for now. attach-modal-dialogs settings is
relevant to this issue.

Closes #387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ignore move op for unresizable and skip_taskbar windows Leleat/Tiling-Assistant
1 participant
@amethystgosling163