Skip to content

Commit 462df79

Browse files
add length limits to API name
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
1 parent 386cab0 commit 462df79

File tree

3 files changed

+25
-4
lines changed

3 files changed

+25
-4
lines changed

pkg/cluster-operator/customcluster_helper.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,21 @@ func generateClusterConfigKey(customCluster *v1alpha1.CustomCluster) client.Obje
283283
}
284284

285285
func generateClusterHostsName(customCluster *v1alpha1.CustomCluster) string {
286-
return customCluster.Name + "-" + ClusterHostsName
286+
name := customCluster.Name + "-" + ClusterHostsName
287+
name = strings.ToLower(name)
288+
if len(name) > 63 {
289+
name = name[:63]
290+
}
291+
return name
287292
}
288293

289294
func generateClusterConfigName(customCluster *v1alpha1.CustomCluster) string {
290-
return customCluster.Name + "-" + ClusterConfigName
295+
name := customCluster.Name + "-" + ClusterConfigName
296+
name = strings.ToLower(name)
297+
if len(name) > 63 {
298+
name = name[:63]
299+
}
300+
return name
291301
}
292302

293303
func generateOwnerRefFromCustomCluster(customCluster *v1alpha1.CustomCluster) metav1.OwnerReference {

pkg/cluster-operator/customcluster_scale.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,12 @@ func generateScaleUpHostsKey(customCluster *v1alpha1.CustomCluster) client.Objec
234234
}
235235

236236
func generateScaleUpHostsName(customCluster *v1alpha1.CustomCluster) string {
237-
return customCluster.Name + "-" + ClusterHostsName + "-scale-up"
237+
name := customCluster.Name + "-" + ClusterHostsName + "-scale-up"
238+
name = strings.ToLower(name)
239+
if len(name) > 63 {
240+
name = name[:63]
241+
}
242+
return name
238243
}
239244

240245
// generateScaleDownManageCMD generate a kubespray cmd to delete the node from the list of nodesNeedDelete.

pkg/fleet-manager/backup/shared.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import (
1919
"fmt"
2020
"reflect"
2121
"sort"
22+
"strings"
2223
"time"
2324

2425
"github.com/robfig/cron/v3"
@@ -241,7 +242,12 @@ func generateVeleroResourceObjectMeta(veleroResourceName string, labels map[stri
241242

242243
// generateVeleroResourceName generate a name uniquely across object store
243244
func generateVeleroResourceName(clusterName, creatorKind, creatorNamespace, creatorName string) string {
244-
return clusterName + "-" + creatorKind + "-" + creatorNamespace + "-" + creatorName
245+
name := clusterName + "-" + creatorKind + "-" + creatorNamespace + "-" + creatorName
246+
name = strings.ToLower(name)
247+
if len(name) > 63 {
248+
name = name[:63]
249+
}
250+
return name
245251
}
246252

247253
// MostRecentCompletedBackup returns the most recent backup that's completed from a list of backups.

0 commit comments

Comments
 (0)