Skip to content

Commit 9fc1c78

Browse files
committed
Temporarily disable some inductor tests on windows
These tests require that the `cl` compiler is available and this may take some setup.
1 parent 953a914 commit 9fc1c78

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

thunder/tests/test_autocast.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import itertools
2+
import platform
23

34
import pytest
45
import torch
@@ -140,7 +141,9 @@ def func(a, b):
140141
assert output.dtype == (torch.float16 if torch_device.type == "cuda" else torch.bfloat16)
141142

142143

143-
@pytest.mark.skipif(not is_inductor_supported(), reason="inductor unsupported")
144+
# Disabling on windows temporarily, until our windows runners source the
145+
# appropriate visual studio config.
146+
@pytest.mark.skipif(not is_inductor_supported() or platform.system() == "Windows", reason="inductor unsupported")
144147
def test_torch_compile_autocast():
145148
"""Checks if our autocast decorator plays well with ``torch.compile``"""
146149

thunder/tests/test_torch_compile_executor.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import platform
12
import pytest
23
import torch
34
from torch._dynamo import is_inductor_supported
@@ -15,7 +16,9 @@ def test_supported_ops_are_in_pytorch_executor():
1516
assert supported_ops - pytorch_ex.implmap.keys() == set()
1617

1718

18-
@pytest.mark.skipif(not is_inductor_supported(), reason="inductor unsupported")
19+
# Disabling on windows temporarily, until our windows runners source the
20+
# appropriate visual studio config.
21+
@pytest.mark.skipif(not is_inductor_supported() or platform.system() == "Windows", reason="inductor unsupported")
1922
def test_torch_compile_litgpt():
2023
from litgpt.model import GPT
2124

0 commit comments

Comments
 (0)