Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_include_te_fp8_autocast as CompileOption instead of an attribute to Trace #1050

Open
kshitij12345 opened this issue Aug 26, 2024 · 3 comments · May be fixed by #1473
Open

_include_te_fp8_autocast as CompileOption instead of an attribute to Trace #1050

kshitij12345 opened this issue Aug 26, 2024 · 3 comments · May be fixed by #1473
Labels
enhancement New feature or request thunderfx for things that could be applicable to the dynamo+thunder frontend TransformerEngine

Comments

@kshitij12345
Copy link
Collaborator

          Makes me wonder whether this could / should be a compile data information ("option") rather than on the trace?

Originally posted by @t-vi in #1021 (comment)

@kshitij12345
Copy link
Collaborator Author

The reason it is an attribute currently is that we only want to wrap fp8_autocast for forward trace and currently there isn't a mechanism to find if the trace is forward trace. (One way could be checking if the name is augment_forward but that seemed brittle).

@t-vi
Copy link
Collaborator

t-vi commented Aug 26, 2024

Naive question: Could this be inferred form the te symbols in the trace?

@kshitij12345
Copy link
Collaborator Author

Naive question: Could this be inferred form the te symbols in the trace?

This could be the answer 😄 , yes - we should mostly be able to infer that based on the te symbols in trace. Though not from id as these symbols are created on the fly but their names.

def _create_fp8_linear_bound_symbol(

@tfogal tfogal added the thunderfx for things that could be applicable to the dynamo+thunder frontend label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request thunderfx for things that could be applicable to the dynamo+thunder frontend TransformerEngine
Projects
None yet
3 participants