Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Indexing with boolean masks #126

Open
nikitaved opened this issue Apr 3, 2024 · 0 comments
Open

[feature request] Indexing with boolean masks #126

nikitaved opened this issue Apr 3, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed operators

Comments

@nikitaved
Copy link
Contributor

nikitaved commented Apr 3, 2024

🚀 Feature

No indexing with boolean mask, for example:

import torch; import thunder                                                                                   
m = x <= 0.5
                                                                                                                                                                                                                          
def f(x, m):                                                                                                   
    return x[m]                                    
                                                                                                        
                                                                                                                       
jf = thunder.jit(f)                                
jf(x, m)  

fails with

RuntimeError: Advanced indexing currently only supports zero or one-dimensional integer tensors, but found a tensor with dtype bool8 and 1 dimensions

cc @apaz-cli

@nikitaved nikitaved added enhancement New feature or request help wanted Extra attention is needed operators labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed operators
Projects
None yet
Development

No branches or pull requests

1 participant