Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Qwen2.5-7B-Instruct model #1286

Open
tfogal opened this issue Oct 10, 2024 · 2 comments
Open

Support Qwen2.5-7B-Instruct model #1286

tfogal opened this issue Oct 10, 2024 · 2 comments
Assignees
Labels
blocks NeMo huggingface For supporting HF models nemo Issues needed to support NVIDIA NeMo models. program-coverage Requests for model and program coverage thunderfx for things that could be applicable to the dynamo+thunder frontend

Comments

@tfogal
Copy link
Collaborator

tfogal commented Oct 10, 2024

🚀 Model / language coverage

Support the Qwen/Qwen2.5-7B-Instruct model.

Pitch

This is an ask from internal NVIDIA colleagues.

Minimal Repro

TBD.

cc @tfogal

@tfogal tfogal added nemo Issues needed to support NVIDIA NeMo models. program-coverage Requests for model and program coverage thunderfx for things that could be applicable to the dynamo+thunder frontend blocks NeMo huggingface For supporting HF models labels Oct 10, 2024
@tfogal tfogal changed the title Support Qwen2-VL model Support Qwen2.5-7B-Instruct model Oct 23, 2024
@tfogal
Copy link
Collaborator Author

tfogal commented Oct 23, 2024

The NeMo team simplified this to a non-VL variant of the model.

@IvanYashchuk
Copy link
Collaborator

#1406 adds a non-VL variant of the Qwen 2 model to Thunder's CI. Currently backward doesn't work because of NVIDIA/Fuser#871 (comment).

We still need to continue with performance analysis and microbenchmarks to improve parts of Qwen 2 (and other two important HF models Phi 3, NeMo Mistral) that do work with nvFuser fusing backward operations. @riccardofelluga, could you please lead this effort? It would also be useful to identify what layer causes nvFuser to fail for the backward computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks NeMo huggingface For supporting HF models nemo Issues needed to support NVIDIA NeMo models. program-coverage Requests for model and program coverage thunderfx for things that could be applicable to the dynamo+thunder frontend
Projects
None yet
Development

No branches or pull requests

3 participants