You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Besides the repro function, we also want to include the information (in the form of comments) describing how thunder segmented the program, and what operations were sent to inductor (and thus unsupported by thunder)
Motivation
Debuggability improvement. Pulling repros out of dependencies is important for dev velocity.
Pitch
I'm thinking about adding the split module structure and the split_reason in the subgraph_info in the comment of the repro script
"""
The graph is splited in 3 submodules:
GraphModule(
(thunder_1): ThunderModule(
(_model): GraphModule()
)
(inductor_2): OptimizedModule(
(_orig_mod): GraphModule()
)
(thunder_3): ThunderModule(
(_model): GraphModule()
)
Break reasons:
Break Reason 1:
node with name: sinc and target: <built-in method sinc of type object at 0x72c659c6a080> only has an automatic torch fallback in thunder.
"""
Adding the splits and their reasons would be great! Adding them as a comment makes sense.
In the future it may be interesting to think about reproducing each split separately, or even reproducing arbitrary subgraphs from the FX graph. Features like that might need to be careful about replicating context manager enters and exits they're contained within.
🚀 Feature
As a follow-up of #1380
Besides the repro function, we also want to include the information (in the form of comments) describing how thunder segmented the program, and what operations were sent to inductor (and thus unsupported by thunder)
Motivation
Debuggability improvement. Pulling repros out of dependencies is important for dev velocity.
Pitch
I'm thinking about adding the split module structure and the
split_reason
in thesubgraph_info
in the comment of the repro scriptcc: @mruberry @tfogal @IvanYashchuk
cc @apaz-cli
The text was updated successfully, but these errors were encountered: