Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable failing tests with dynamo #1471

Open
t-vi opened this issue Nov 26, 2024 · 1 comment
Open

Reenable failing tests with dynamo #1471

t-vi opened this issue Nov 26, 2024 · 1 comment
Labels
dynamo thunderfx for things that could be applicable to the dynamo+thunder frontend

Comments

@t-vi
Copy link
Collaborator

t-vi commented Nov 26, 2024

The following will be disabled due to failures with PyTorch 2.6 dev (internal dynamo changes in PT nightly?):

FAILED thunder/tests/test_recipes.py::test_recipe_basic_bert_dynamo - NotImplementedError: VJP for PrimIDs.ITEM is not implemented
FAILED thunder/tests/test_dynamo.py::test_thundercompiler_optim_step_DynamoThunder_cuda_thunder.dtypes.float32[adam] - torch._dynamo.exc.BackendCompilerFailed: backend='<thunder.dynamo.compiler.ThunderCompiler object at 0x7f4970307490>' raised:
FAILED thunder/tests/test_dynamo.py::test_thundercompiler_optim_step_DynamoThunder_cuda_thunder.dtypes.float32[adamw] - torch._dynamo.exc.BackendCompilerFailed: backend='<thunder.dynamo.compiler.ThunderCompiler object at 0x7f07282833a0>' raised:
FAILED thunder/tests/test_networks.py::test_thunderfx_mistral_nemo_small - NotImplementedError: VJP for PrimIDs.ITEM is not implemented
FAILED thunder/tests/test_networks.py::test_hf_for_nemo[Qwen/Qwen2.5-7B-Instruct] - NotImplementedError: VJP for PrimIDs.ITEM is not implemented
FAILED thunder/tests/test_networks.py::test_hf_for_nemo[microsoft/Phi-3-mini-128k-instruct] - NotImplementedError: VJP for PrimIDs.ITEM is not implemented
FAILED thunder/tests/test_networks.py::test_nanogpt_gelu_DynamoThunder_cuda_thunder.dtypes.float32 - torch._dynamo.exc.BackendCompilerFailed: backend='<thunder.dynamo.compiler.ThunderCompiler object at 0x7f51b3b57100>' raised:
@t-vi t-vi added dynamo thunderfx for things that could be applicable to the dynamo+thunder frontend labels Nov 26, 2024
@IvanYashchuk
Copy link
Collaborator

Here's the missing vjp/grad rule issue for prims.item: #1479.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamo thunderfx for things that could be applicable to the dynamo+thunder frontend
Projects
None yet
Development

No branches or pull requests

2 participants