Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable rematerialization by default after a memory-aware way is found #1562

Open
t-vi opened this issue Dec 17, 2024 · 0 comments
Open

re-enable rematerialization by default after a memory-aware way is found #1562

t-vi opened this issue Dec 17, 2024 · 0 comments

Comments

@t-vi
Copy link
Collaborator

t-vi commented Dec 17, 2024

#1560 temporarily disables rematerialization by default to mitigate #1337

What happens is that it tries to fuse all nonlinearities, which works if you compute all pre-nonlinearity-activations at once and the put them into the fusion.
So I think we fundamentally need a memory-aware way of moving operations around for things like rematerialization.
One thing could be to not do the full graph approach but try some local surgery.

cc @riccardofelluga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant