Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid joint trace in rematerialize forward backward #1618

Open
t-vi opened this issue Jan 8, 2025 · 1 comment
Open

avoid joint trace in rematerialize forward backward #1618

t-vi opened this issue Jan 8, 2025 · 1 comment
Labels
rematerialization

Comments

@t-vi
Copy link
Collaborator

t-vi commented Jan 8, 2025 •
edited
Loading

In #1615 we had to temporarily disable rematerialization because it seems to generate funny flow graphs when symbols are duplicate. We re-enabled it in #1622, but it may be more robust to not need to do the joint trace but instead construct the graph and then process the forward and (in particular) backward separately.
@t-vi t-vi changed the title reenable rematerialize forward backward avoid joint trace in rematerialize forward backward Jan 9, 2025
@t-vi t-vi mentioned this issue Jan 9, 2025
Merged
@tfogal
Copy link
Collaborator

tfogal commented Jan 10, 2025

Hey @t-vi is this still open given #1622?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rematerialization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfogal @t-vi