Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tensor.type #177

Closed
Tracked by #179 ...
tfogal opened this issue Apr 12, 2024 · 3 comments · Fixed by #273
Closed
Tracked by #179 ...

Implement Tensor.type #177

tfogal opened this issue Apr 12, 2024 · 3 comments · Fixed by #273
Labels
enhancement New feature or request MegatronImagen Needed to support NeMo's MegatronImagen model (text to image generation) nemo Issues needed to support NVIDIA NeMo models.

Comments

@tfogal
Copy link
Collaborator

tfogal commented Apr 12, 2024

🚀 Feature

Implement Tensor.type

Motivation

NeMo text-to-image model.

cc @tfogal

@tfogal tfogal added enhancement New feature or request nemo Issues needed to support NVIDIA NeMo models. MegatronImagen Needed to support NeMo's MegatronImagen model (text to image generation) labels Apr 12, 2024
@k223kim k223kim mentioned this issue Apr 25, 2024
4 tasks
@k223kim
Copy link
Contributor

k223kim commented Apr 25, 2024

Hi Team! I have made a rough draft of the implementation of Tensor.type. I was not sure how to implement non_blocking at the moment. As per this description, it states the following:

If True, and the source is in pinned memory and destination is on the GPU or vice versa, the copy is performed asynchronously with respect to the host. Otherwise, the argument has no effect.

How do I know the source and destination from the input arguments of Tensor.type? Also, I am not sure where to put the test case for this implementation. Any suggestions and feedback would be appreciated!

@t-vi
Copy link
Collaborator

t-vi commented Apr 26, 2024

@tfogal It's cool that we want to support it, but in terms of good style, NeMo should really be using .to, .is_cuda and .dtype instead, which is the much more standard way to do what is does (and much more efficient).

@tfogal
Copy link
Collaborator Author

tfogal commented May 1, 2024

triage team: let's figure out how to guide Kaeun here.

@t-vi ack. need to figure out where these are coming from (could be megatron core, for example) before I can track on GitHub, but I added it to my personal list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MegatronImagen Needed to support NeMo's MegatronImagen model (text to image generation) nemo Issues needed to support NVIDIA NeMo models.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants