Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thunder is 10**6 times slower than Lightning #46

Closed
kurmukovai opened this issue Mar 22, 2024 · 3 comments
Closed

Thunder is 10**6 times slower than Lightning #46

kurmukovai opened this issue Mar 22, 2024 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kurmukovai
Copy link

🐛 Bug

I feel like marketing is misleading, as thunder is 1_000_000 times slower than lightning^[1,2]

image

  1. https://en.wikipedia.org/wiki/Speed_of_light
  2. https://en.wikipedia.org/wiki/Speed_of_sound
@kurmukovai kurmukovai added bug Something isn't working help wanted Extra attention is needed labels Mar 22, 2024
@lantiga
Copy link
Collaborator

lantiga commented Mar 22, 2024

😁 Right but AI helps us defy the laws of physics (Karpathy) 😅

or more simply, the first run is slower due to compilation times (@nikitaved)

@lantiga lantiga closed this as completed Mar 22, 2024
@nikitaved
Copy link
Contributor

nikitaved commented Mar 22, 2024

But on a serious note :) @kurmukovai , as @lantiga pointed out, the initial run could be slow because of the compilation/program analysis step. Note, however, that changes in inputs' meta-data (like device, shapes, but not the data itself) may trigger re-compilation.

Once meta-data is fixed and is not expected to change, the goal is to suffer a single initial warm-up perf hit for faster subsequent runs (for example, during inference).

If meta-data is expected to vary (say, like in the streaming setting), but this set is finite, one could cache compiled models to avoid non-stop re-compilations.

@Andrei-Aksionov
Copy link

Thunder, feel the thunder
Lightning, then the thunder

(Imaging Dragons - Thunder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants