Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cudnnex SDPA checkers more conservative. #58

Closed
wujingyue opened this issue Mar 22, 2024 · 1 comment
Closed

Make cudnnex SDPA checkers more conservative. #58

wujingyue opened this issue Mar 22, 2024 · 1 comment
Assignees
Labels
cudnn enhancement New feature or request

Comments

@wujingyue
Copy link
Collaborator

#57's description and https://github.com/Lightning-AI/lit-thunder-LEGACY/pull/2480#issuecomment-2013537240 have the context.

The proposed improvement is to properly propagate graph-not-supported errors from the cudnn backend to the frontend as distinguishable exceptions. This way, we can make the checkers to only reject unsupported graphs and not hiding other programming errors.

@wujingyue wujingyue added bug Something isn't working help wanted Extra attention is needed labels Mar 22, 2024
@wujingyue wujingyue added enhancement New feature or request cudnn and removed bug Something isn't working help wanted Extra attention is needed labels Mar 22, 2024
@vedaanta
Copy link
Collaborator

#427

Closing as the issue had already been addressed in above PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudnn enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants