Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically add executor for "executor-linked" symbols #732

Open
t-vi opened this issue Jul 9, 2024 · 0 comments
Open

automatically add executor for "executor-linked" symbols #732

t-vi opened this issue Jul 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@t-vi
Copy link
Collaborator

t-vi commented Jul 9, 2024

Idea: implement automatically adding the default executor for special-purpose symbols - i.e. the ability for symbols to request "if you see me and don't have any other executor for it, include executor foo".

Apparently, we often have transforms that introduce new symbols linked to one particular executor.

This means that the user has to apply the transform and specify the executor to be used in addition to the transform where it would seem to be evident that we need it for the new symbol.

So for e.g. quantization you currently need

 jm = thunder.jit(
        model_fp_reference,
        executors=(bitsandbytes_executor,),
        early_transforms=[BitsAndBytesLinearQuant4bit()],
    )

but clearly, the bnb_matmul_nf4 added to the graph by BitsAndBytesLinearQuant4bit belongs to the bitsandbytes_executor, so why would the user need to specify executors here (and decide whether they also want the default executors or not etc...).

This is from a discussion with @tfogal

@t-vi t-vi added the enhancement New feature or request label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant