fix: sonar fixes (#223)

Author: ReenigneArcher

examples/jekyll/assets/js/crowdin-init.js

@@ -1 +1 @@
-window.initCrowdIn('LizardByte-docs', null);
+globalThis.initCrowdIn('LizardByte-docs', null);

examples/jekyll/assets/js/discord-init.js

@@ -1 +1 @@
-window.initCrowdIn('LizardByte-docs', 'sphinx')
+globalThis.initCrowdIn('LizardByte-docs', 'sphinx')

examples/sphinx/source/_static/js/crowdin.js

@@ -15,8 +15,8 @@ function formatNumber(num, decimalPlaces = 1) {
 }
 
 // Expose to the global scope
-if (typeof window !== 'undefined') {
-    window.formatNumber = formatNumber;
+if (globalThis.window !== undefined) {
+    globalThis.formatNumber = formatNumber;
 }
 
 module.exports = formatNumber;

src/js/format-number.js

@@ -40,8 +40,8 @@ function levenshteinDistance(a, b) {
 }
 
 // Expose to the global scope
-if (typeof window !== 'undefined') {
-    window.levenshteinDistance = levenshteinDistance;
+if (globalThis.window !== undefined) {
+    globalThis.levenshteinDistance = levenshteinDistance;
 }
 
 module.exports = levenshteinDistance;

src/js/levenshtein-distance.js

@@ -20,8 +20,8 @@ function loadScript(url, callback) {
 }
 
 // Expose to the global scope
-if (typeof window !== 'undefined') {
-    window.loadScript = loadScript;
+if (globalThis.window !== undefined) {
+    globalThis.loadScript = loadScript;
 }
 
 module.exports = loadScript;

src/js/load-script.js

@@ -10,22 +10,19 @@ function rankingSorter(firstKey, secondKey) {
             return -1;
         } else if (a[firstKey] < b[firstKey]) {
             return 1;
-        }
-        else {
-            if (a[secondKey] > b[secondKey]) {
-                return 1;
-            } else if (a[secondKey] < b[secondKey]) {
-                return -1;
-            } else {
-                return 0;
-            }
+        } else if (a[secondKey] > b[secondKey]) {
+            return 1;
+        } else if (a[secondKey] < b[secondKey]) {
+            return -1;
+        } else {
+            return 0;
         }
     }
 }
 
 // Expose to the global scope
-if (typeof window !== 'undefined') {
-    window.rankingSorter = rankingSorter;
+if (globalThis.window !== undefined) {
+    globalThis.rankingSorter = rankingSorter;
 }
 
 module.exports = rankingSorter;

src/js/ranking-sorter.js

@@ -8,8 +8,8 @@ function sleep(ms) {
 }
 
 // Expose to the global scope
-if (typeof window !== 'undefined') {
-    window.sleep = sleep;
+if (globalThis.window !== undefined) {
+    globalThis.sleep = sleep;
 }
 
 module.exports = sleep;

src/js/sleep.js

@@ -49,7 +49,7 @@ describe('initCrowdIn', () => {
     afterEach(() => {
         jest.clearAllMocks();
         jest.useRealTimers();
-        delete global.window.proxyTranslator;
+        delete globalThis.window.proxyTranslator;
         delete globalThis._crowdinMirrorInstalled;
     });
 
@@ -84,7 +84,7 @@ describe('initCrowdIn', () => {
         // Simulate script loading
         jest.runAllTimers();
 
-        expect(window.proxyTranslator.init).toHaveBeenCalledWith(
+        expect(globalThis.proxyTranslator.init).toHaveBeenCalledWith(
             expect.objectContaining({
                 baseUrl: "http://localhost",
                 distribution: "d6c830ba4b41106fefe5d391bw4",

tests/crowdin.test.js

@@ -16,7 +16,7 @@ describe('sleep function', () => {
     })
 
     beforeEach(() => {
-        jest.spyOn(global, 'setTimeout');
+        jest.spyOn(globalThis, 'setTimeout');
     });
 
     test.each([