Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify PySB to detect dangling bonds #21

Open
lh64 opened this issue Aug 21, 2015 · 3 comments
Open

Modify PySB to detect dangling bonds #21

lh64 opened this issue Aug 21, 2015 · 3 comments

Comments

@lh64
Copy link

lh64 commented Aug 21, 2015

Currently, patterns like A(b=1) % B(a=2) are allowed in PySB. These are examples of dangling bonds that should be illegal, and formally are in BNGL. Unfortunately, however, BNG does not currently have any code for detecting dangling bonds, so they are actually legal syntax in practice. Therefore, if a PySB rule is accidentally created with dangling bonds (which has happened, see Issue #9 ) there is nothing currently to detect and prevent this. It probably makes sense for us to implement a dangling bond detector at the PySB level since it's unclear when (if ever) this issue will be resolved in the BNG code.

@lh64 lh64 added this to the Discussion at HMS milestone Aug 21, 2015
@alubbock
Copy link

alubbock commented Dec 2, 2017

@lh64 Detecting dangling bonds should be straightforward, but should they cause a Python warning, or an error?

@lh64
Copy link
Author

lh64 commented Dec 4, 2017

It's illegal syntax, so I think an error.

@alubbock
Copy link

alubbock commented Dec 4, 2017

Implemented in pysb#328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants