From 0e3fcd90fa5dcd7ff1e1fb9edab07ce591194c44 Mon Sep 17 00:00:00 2001
From: James Huang <jhuang2003@yahoo.ca>
Date: Sun, 23 Jul 2023 16:30:15 -0400
Subject: [PATCH] made password field editable without clicking icon

---
 dashboard/src/components/Atoms/Config/InputBox.tsx | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/dashboard/src/components/Atoms/Config/InputBox.tsx b/dashboard/src/components/Atoms/Config/InputBox.tsx
index a25bd46e..1e2e5b2a 100644
--- a/dashboard/src/components/Atoms/Config/InputBox.tsx
+++ b/dashboard/src/components/Atoms/Config/InputBox.tsx
@@ -170,7 +170,8 @@ export default function InputBox({
 
   let icons = [];
 
-  if (typeModified !== 'password' && touched) {
+  // enable editing regardless of input type
+  if (touched) {
     icons.push(
       <FontAwesomeIcon
         icon={faFloppyDisk}
@@ -200,7 +201,8 @@ export default function InputBox({
           typeModified === 'password'
             ? setTypeModified('text')
             : setTypeModified('password');
-          formRef.current?.reset();
+          // allow in-progress password to persist between hide/show
+          // formRef.current?.reset();
         }}
         key="reveal password"
       />
@@ -255,7 +257,7 @@ export default function InputBox({
           </div>
         </div>
         <input
-          value={typeModified === 'password' ? 'xxxxxxxx' : value}
+          value={value}
           placeholder={placeholder}
           onChange={onChange}
           maxLength={maxLength}
@@ -267,7 +269,7 @@ export default function InputBox({
           onBlur={() => {
             setValue(value.trim());
           }}
-          disabled={typeModified === 'password' ? true : disabled}
+          disabled={disabled}
           type={typeModified}
           autoComplete={DISABLE_AUTOFILL}
         />