Skip to content

Commit 0581065

Browse files
committed
Fix #6
Accesed Dependency object without checking the thread.
1 parent d68cd4f commit 0581065

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

MusicPlayer/Pages/ShellPage.xaml.cs

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,15 @@ private async void ShellPage_Loaded(object sender, RoutedEventArgs e)
103103
private async void App_ErrorOccured(object sender, EventArgs<(Exception exception, ErroType erroType)> e)
104104
{
105105
string caption = null;
106+
if (!this.Dispatcher.HasThreadAccess)
107+
{
106108

109+
await this.Dispatcher.RunAsync(Windows.UI.Core.CoreDispatcherPriority.Normal, () =>
110+
{
111+
this.App_ErrorOccured(sender, e);
112+
});
113+
return;
114+
}
107115
if (sender is DownloadItem downloadItem)
108116
{
109117
var albumName = downloadItem.Song?.AlbumName;
@@ -158,14 +166,13 @@ private async void App_ErrorOccured(object sender, EventArgs<(Exception exceptio
158166
else
159167
message = "We could not find the error. Sorry this should not happen.";
160168

161-
await this.RunOnDispatcher(async () =>
169+
170+
var dialog = new MessageDialog(message, caption)
162171
{
163-
var dialog = new MessageDialog(message, caption)
164-
{
165-
Options = MessageDialogOptions.None
166-
};
167-
await dialog.ShowAsync();
168-
});
172+
Options = MessageDialogOptions.None
173+
};
174+
await dialog.ShowAsync();
175+
169176

170177
}
171178

0 commit comments

Comments
 (0)