IDE0055 false positive with LF line endings (OSOE-344)

[sarahelsaig]

This is our follow-up issue once dotnet/roslyn#55526 is fixed.

What's the problem?

In Git repositories, it's common to use LF (\n, "Unix-style") line endings for better cross-platform compatibility (see Lombiq/Open-Source-Orchard-Core-Extensions#65). The problem is that with .cs files, if we have LF line endings instead of CRLF (\r\n, "Windows-style") then roslyn will emit several false-positive IDE0055 warnings. There is a workaround of making only the .cs files CRLF as described in the above-linked issue. We have applied it to this repo and its submodules during OSOE-49.

What needs to be done?

Once the analyzer is fixed, the *.cs text eol=crlf rule should be removed from all .gitattributes files and then all .cs files should be renormalized to LF using the same steps described in the issue description of OSOE-91.

Jira issue

[wAsnk]

It just happened in Lombiq/Hosting-Media-Theme#33

[Piedone]

We could, or most possibly would need to, remove the end_of_line config from .editorconfig too:

.NET-Analyzers/Lombiq.Analyzers/.editorconfig

Line 17 in 5506480

end_of_line = crlf