Fix: Lists Screen #728
Merged
Fix: Lists Screen #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # presentation/src/main/java/com/london/presentation/feature/account/rating/MyRatingScreen.kt # presentation/src/main/java/com/london/presentation/feature/category/main/CategoriesScreen.kt # presentation/src/main/java/com/london/presentation/feature/details/actor/ActorDetailsScreen.kt # presentation/src/main/java/com/london/presentation/feature/details/actor/info/gallery/ActorsGalleryScreen.kt # presentation/src/main/java/com/london/presentation/feature/details/movie/MovieDetailsScreen.kt # presentation/src/main/java/com/london/presentation/feature/details/tvshow/episode/EpisodeDetailScreen.kt # presentation/src/main/java/com/london/presentation/feature/details/tvshow/info/TvShowDetailScreen.kt # presentation/src/main/java/com/london/presentation/feature/home/HomeScreen.kt # presentation/src/main/java/com/london/presentation/feature/home/trending/movie/TrendingMoviesScreen.kt # presentation/src/main/java/com/london/presentation/feature/home/trending/tvshow/TrendingTvShowsScreen.kt # presentation/src/main/java/com/london/presentation/feature/list/savedlist/ListsScreen.kt # presentation/src/main/java/com/london/presentation/feature/reviews/ReviewsScreen.kt # presentation/src/main/java/com/london/presentation/shared/buildscreen/NetworkErrorScreen.kt
This commit updates the spelling of "Log In" to "Login" across various string resources for consistency. Changed strings: - `login_to_create_list` - `login_to_add_list` - `login` - `login_to_your_account` - `please_login_to_access` - `logout` (changed from "Log Out")
This commit updates the `what_to_watch` string resource in `presentation/src/main/res/values/strings.xml` to "What to watch?" for brevity.
This commit updates the `EmptyLayout` composable function. - It now wraps its content within a `Box` layout. - A `BackgroundGradient` is added at the top start of the `Box`. - The `imageContent` and `additionalContent` lambdas are now invoked using `invoke()`.
This commit introduces a new field `isSnackBarErrorVisible` to the `ListUiState` data class. This boolean flag will be used to control the visibility of an error snackbar in the list feature, providing users with feedback when an operation fails.
This commit refactors the `ViewItems` feature to `MovieListDetails` for better clarity and consistency.
Key changes:
- Renamed classes:
- `ViewItemsScreen.kt` to `MovieListDetailsScreen.kt`
- `ViewItemsViewModel.kt` to `MovieListDetailsViewModel.kt`
- `ViewItemsContract.kt` to `MovieListDetailsContract.kt`
- `ViewItemsUiState.kt` to `MovieListUiState.kt`
- `ViewItemsEffect.kt` to `MovieListEffect.kt`
- Updated package names from `com.london.presentation.feature.list.viewitems` to `com.london.presentation.feature.list.details`.
- Updated references in `DeleteListBottomSheet.kt` and `mainNavGraph.kt` to reflect the new names.
This commit introduces several improvements to the `ListsScreen` and `ListViewModel`: **ListsScreen.kt:** - Renamed `SavedListItemRow` to `MovieListCard` for better clarity. - Renamed `NoListFoundAsGuest` to `GuestContent`. - Used `items(pagingItems.itemSnapshotList)` for better performance and stability in the `LazyColumn`. - Display snackbar based on `state.isSnackBarErrorVisible` instead of `state.error != null`. - Minor UI adjustment in `GuestContent` by changing image scale. **ListViewModel.kt:** - Simplified `onAddList` by extracting error handling to `handleAddListFail`. - Reset `addListSheetState` to default `AddSheetState()` on successful list creation for a cleaner user experience. - Set `isSnackBarErrorVisible = true` in `handleAddListFail` to ensure error messages are displayed. - Removed redundant `onStart` logic in `onAddList` that was setting `isSnackBarSuccessVisible` to false. - Simplified the `createListsPagingSource` lambda. - Changed `resetSnackBarErrorState` to set `isSnackBarErrorVisible` to `false`.
Contributor
|
[London Bot] Metrics Update Status 📊 PR metrics successfully updated for event: |
Contributor
|
[London Bot] Auto-update Status ✅ Branch successfully updated from |
Code Coverage Summary
|
# Conflicts: # presentation/src/main/java/com/london/presentation/feature/account/rating/MyRatingScreen.kt # presentation/src/main/java/com/london/presentation/feature/authentication/login/LoginScreen.kt # presentation/src/main/java/com/london/presentation/feature/list/savedlist/ListsScreen.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.