From 457e04482d2e8ffaad076db3dc28b313fc4f7cc2 Mon Sep 17 00:00:00 2001
From: rly <rly@lbl.gov>
Date: Wed, 25 Sep 2024 09:56:38 -0700
Subject: [PATCH] Remove resolution_in_pixels from CameraDevice

---
 spec/ndx-franklab-novela.extensions.yaml         |  8 --------
 .../spec/ndx-franklab-novela.extensions.yaml     | 16 ----------------
 src/spec/create_extension_spec.py                |  8 --------
 3 files changed, 32 deletions(-)

diff --git a/spec/ndx-franklab-novela.extensions.yaml b/spec/ndx-franklab-novela.extensions.yaml
index 6f0e520..dbd2a36 100644
--- a/spec/ndx-franklab-novela.extensions.yaml
+++ b/spec/ndx-franklab-novela.extensions.yaml
@@ -87,14 +87,6 @@ groups:
     dtype: float
     doc: Frame rate of the camera, in frames per second.
     required: false
-  - name: resolution_in_pixels
-    dtype: int
-    dims:
-    - w h
-    shape:
-    - 2
-    doc: Width and height of the camera video in pixels, e.g., (1292, 964).
-    required: false
 - neurodata_type_def: HeaderDevice
   neurodata_type_inc: Device
   doc: metadata from global configuration from header
diff --git a/src/pynwb/ndx_franklab_novela/spec/ndx-franklab-novela.extensions.yaml b/src/pynwb/ndx_franklab_novela/spec/ndx-franklab-novela.extensions.yaml
index f7bcba2..dbd2a36 100644
--- a/src/pynwb/ndx_franklab_novela/spec/ndx-franklab-novela.extensions.yaml
+++ b/src/pynwb/ndx_franklab_novela/spec/ndx-franklab-novela.extensions.yaml
@@ -83,22 +83,10 @@ groups:
   - name: lens
     dtype: text
     doc: lens info
-  - name: serial_number
-    dtype: text
-    doc: Serial number of the camera.
-    required: false
   - name: frame_rate
     dtype: float
     doc: Frame rate of the camera, in frames per second.
     required: false
-  - name: resolution_in_pixels
-    dtype: int
-    dims:
-    - w h
-    shape:
-    - 2
-    doc: Width and height of the camera video in pixels, e.g., (1292, 964).
-    required: false
 - neurodata_type_def: HeaderDevice
   neurodata_type_inc: Device
   doc: metadata from global configuration from header
@@ -208,10 +196,6 @@ groups:
     enters the rectangle, then every time the particular theta phase is detected,
     immediately apply one stimulation bout (accounting for the lockout period).
   datasets:
-  - name: experimenter
-    neurodata_type_inc: VectorData
-    dtype: text
-    doc: Name of the experimenter.
   - name: epoch_name
     neurodata_type_inc: VectorData
     dtype: text
diff --git a/src/spec/create_extension_spec.py b/src/spec/create_extension_spec.py
index 77d9cf8..b2f7201 100644
--- a/src/spec/create_extension_spec.py
+++ b/src/spec/create_extension_spec.py
@@ -169,14 +169,6 @@ def main():
                 dtype="float",
                 required=False,
             ),
-            NWBAttributeSpec(
-                name="resolution_in_pixels",
-                doc=("Width and height of the camera video in pixels, e.g., (1292, 964)."),
-                dtype="int",
-                shape=(2, ),
-                dims=("w h", ),
-                required=False,
-            ),
         ]
     )