diff --git a/CHANGELOG.md b/CHANGELOG.md index fcd5e57f0..fe345954f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,7 @@ dj.FreeTable(dj.conn(), "common_session.session_group").drop() - Drop `SessionGroup` table #1106 - Improve electrodes import efficiency #1125 + - Fix logger method call in `common_task` #1132 - Decoding @@ -53,6 +54,7 @@ dj.FreeTable(dj.conn(), "common_session.session_group").drop() - Fix bug in `get_group_by_shank` #1096 - Fix bug in `_compute_metric` #1099 - Fix bug in `insert_curation` returned key #1114 + - Fix handling of waveform extraction sparse parameter #1132 ## [0.5.3] (August 27, 2024) diff --git a/src/spyglass/common/common_task.py b/src/spyglass/common/common_task.py index 744d5d773..60fba08d3 100644 --- a/src/spyglass/common/common_task.py +++ b/src/spyglass/common/common_task.py @@ -236,9 +236,9 @@ def get_epoch_interval_name(cls, epoch, session_intervals): if target_interval in interval ] if not possible_targets: - logger.warn(f"Interval not found for epoch {epoch}.") + logger.warning(f"Interval not found for epoch {epoch}.") elif len(possible_targets) > 1: - logger.warn( + logger.warning( f"Multiple intervals found for epoch {epoch}. " + f"matches are {possible_targets}." ) diff --git a/src/spyglass/spikesorting/v1/metric_curation.py b/src/spyglass/spikesorting/v1/metric_curation.py index b9d1fb66f..8346f8ddd 100644 --- a/src/spyglass/spikesorting/v1/metric_curation.py +++ b/src/spyglass/spikesorting/v1/metric_curation.py @@ -263,10 +263,13 @@ def make(self, key): os.makedirs(waveforms_dir, exist_ok=True) logger.info("Extracting waveforms...") + + # Extract non-sparse waveforms by default + waveform_params.setdefault("sparse", False) + waveforms = si.extract_waveforms( recording=recording, sorting=sorting, - sparse=waveform_params.get("sparse", False), folder=waveforms_dir, overwrite=True, **waveform_params,