From a79f9b99c9510e458cb6cf7dfda8ec75798e211f Mon Sep 17 00:00:00 2001
From: Stepan Mikhailiuk <istepancar@gmail.com>
Date: Sun, 7 Jan 2024 20:29:12 -0800
Subject: [PATCH] feat(*): optimize getImageDataAtTime

---
 package.json              |  2 +-
 src/backends/beamcoder.ts | 31 ++++++++++++++-----------------
 2 files changed, 15 insertions(+), 18 deletions(-)

diff --git a/package.json b/package.json
index 4c91665..2943358 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lumen5/framefusion",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "type": "module",
   "scripts": {
     "docs": "typedoc framefusion.ts",
diff --git a/src/backends/beamcoder.ts b/src/backends/beamcoder.ts
index ad7fead..2c950c2 100644
--- a/src/backends/beamcoder.ts
+++ b/src/backends/beamcoder.ts
@@ -246,7 +246,7 @@ export class BeamcoderExtractor extends BaseExtractor implements Extractor {
      * Get imageData for a given time in seconds
      * @param targetTime
      */
-    async getImageDataAtTime(targetTime: number): Promise<ImageData> {
+    async getImageDataAtTime(targetTime: number, target?: Uint8ClampedArray): Promise<ImageData> {
         const targetPts = Math.round(this._timeToPTS(targetTime));
         VERBOSE && console.log('targetTime', targetTime, '-> targetPts', targetPts);
         const frame = await this._getFrameAtPts(targetPts);
@@ -254,7 +254,14 @@ export class BeamcoderExtractor extends BaseExtractor implements Extractor {
             VERBOSE && console.log('no frame found');
             return null;
         }
-        const rawData = this._resizeFrameData(frame);
+
+        let rawData = target;
+
+        if (!target) {
+            rawData = new Uint8ClampedArray(frame.width * frame.height * 4);
+        }
+
+        this._setFrameDataToImageData(frame, rawData);
 
         return {
             data: rawData,
@@ -476,25 +483,15 @@ export class BeamcoderExtractor extends BaseExtractor implements Extractor {
         return packet as Packet;
     }
 
-    _resizeFrameData(frame): Uint8ClampedArray {
-        const components = 4; // 4 components: r, g, b and a
-        const size = frame.width * frame.height * components;
-        const rawData = new Uint8ClampedArray(size); // we should probably reuse this buffer
-        const sourceLineSize = frame.linesize as unknown as number;
+    _setFrameDataToImageData(frame: beamcoder.Frame, target: Uint8ClampedArray) {
         // frame.data can contain multiple "planes" in other colorspaces, but in rgba, there is just one "plane", so
         // our data is in frame.data[0]
         const pixels = frame.data[0] as Uint8Array;
 
-        // libav creates larger buffers because it makes their internal code simpler.
-        // we have to trim a part at the right of each pixel row.
-        for (let i = 0; i < frame.height; i++) {
-            const sourceStart = i * sourceLineSize;
-            const sourceEnd = sourceStart + frame.width * components;
-            const sourceData = pixels.slice(sourceStart, sourceEnd);
-            const targetOffset = i * frame.width * components;
-            rawData.set(sourceData, targetOffset);
-        }
-        return rawData;
+        // libav creates larger buffers by 16 bytes because it makes their internal code simpler.
+        // we have to trim a part at the end.
+
+        target.set(pixels.subarray(0, target.length));
     }
 
     async dispose() {