Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: possibility to revoke/burn a secret #170

Closed
mshedsilegx opened this issue Feb 3, 2024 · 8 comments · Fixed by #193
Closed

Feature request: possibility to revoke/burn a secret #170

mshedsilegx opened this issue Feb 3, 2024 · 8 comments · Fixed by #193
Milestone

Comments

@mshedsilegx
Copy link

I would be helpful to be able to burn or revoke a secret immediately in case of error or mistake, to invalidate it right away.
Similar to the below.
image

If the secret is passphrase protected, the correct passphrase would need to be entered to revoke/burn the secret.

@Luzifer
Copy link
Owner

Luzifer commented Feb 3, 2024

Well, just call the URL you got and retrieve it, it's immediately deleted from the server and therefore gone. (Deleting the secret as soon as it's retrieved once is a core feature of OTS.)

@mshedsilegx
Copy link
Author

I agree, still I think it would more user friendly to be able to revoke a secret via a UI button, without having to view it.

@mshedsilegx
Copy link
Author

Closing, as this feature is only a nice to have,

@Luzifer
Copy link
Owner

Luzifer commented Apr 11, 2024

Closing, as this feature is only a nice to have,

Then why are you closing it, if you want to have it?

@Luzifer Luzifer reopened this Apr 11, 2024
@HappyMan4
Copy link

Hi Luzifer, I've had a few moments when I needed that button.
Let's say you pasted a wrong text into the form and created the secret. Afterwards you realize that you just pasted the wrong text into it.
So the next decision is up to the user - mostly I don't take the time to copy the link and call it so that the server forgets the information. I just leave it as it is, with the default expiry time to expire by itself. On my site this is seven days.
If there would be a button to destroy the information immediately, at least for me, I could see a benefit here.
But indeed, this is just nice to have and nothing more. It's really not important at all.
Just my 2 cents 😊

@mshedsilegx
Copy link
Author

I agree, that was my sentiment originally as well, just did not want to waste valuable development time on a trivial feature.

@Luzifer Luzifer added this to the 1.14.0 milestone Sep 22, 2024
Luzifer added a commit that referenced this issue Sep 22, 2024
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer Luzifer linked a pull request Sep 22, 2024 that will close this issue
@Luzifer
Copy link
Owner

Luzifer commented Sep 22, 2024

@mshedsilegx @HappyMan4 Please have a look at the attached PR (including screenshots) for the implementation draft of this feature.

@mshedsilegx
Copy link
Author

That looks excellent, thank you for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants