Unsorted album appears empty

[jeanas]

Lychee version

Latest master, commit 024b8c2

Which PHP version are you using?

PHP 8.2

Detailed description of the problem

If set to "Public", the "Unsorted" album is visible without logging in, but appears empty ("Nothing to see here").

Furthermore (more problematically from my POV), if I add a tag to an image in the Unsorted album and then create a public tag album for that tag, the image does not appear in the tag album.

Steps to reproduce the issue

1. Make "Unsorted" album public.
2. Log out.
3. Click on "Unsorted" album.
4. Read "Nothing to see here".

Diagnostics [REQUIRED]

Diagnostics
-----------
Warning: /*************e/ is owned by group root, but should be owned by one out of www-data
Warning: /*************e/ has permissions 0770, but should have 2775
Warning: /*************e/medium2x is owned by group root, but should be owned by one out of www-data
Warning: /*************e/medium2x has permissions 0770, but should have 2775
Warning: /*************e/medium2x/ce is owned by group root, but should be owned by one out of www-data
Warning: /*************e/medium2x/ce has permissions 0770, but should have 2775
Warning: /*************e/medium2x/ce/16 is owned by group root, but should be owned by one out of www-data
Warning: /*************e/medium2x/ce/16 has permissions 0770, but should have 2775
Warning: /*************e/medium2x/61 is owned by group root, but should be owned by one out of www-data
Warning: /*************e/medium2x/61 has permissions 0770, but should have 2775
Warning: 1849 more directories with wrong owner
Warning: 1852 more directories with wrong permissions
Warning: Dropbox import not working. dropbox_key is empty.
Warning: You may experience problems when uploading a photo of large size. Take a look in the FAQ for details.
Warning: You may experience problems when uploading a photo of large size. Take a look in the FAQ for details.
Info: Latest version of PHP is 8.3
Warning: Default timezone not properly set; you might experience strange results when importing photos without explicit EXIF timezone

System Information
------------------
Lychee Version (git):                    master (024b8c2) -- Up to date (-4.2966181251265E-6 years ago).
DB Version:                              5.5.1

composer install:                        --no-dev
APP_ENV:                                 production
APP_DEBUG:                               false
APP_URL:                                 set
APP_DIR:                                 default
LOG_VIEWER_ENABLED:                      true
LIVEWIRE_ENABLED:                        true

System:                                  Linux
PHP Version:                             8.2.20
PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
Timezone:                                UTC
Max uploaded file size:                  2M
Max post size:                           8M
Livewire chunk size:                     0.00 B
Max execution time:                      0
MySQL Version:                           10.11.6-MariaDB-0+deb12u1

exec() Available:                        yes
Imagick Available:                       1
Imagick Enabled:                         1
Imagick Version:                         1691
GD Version:                              2.3.3
Number of foreign key:                   12 found.

Config Information
------------------
version:                                 050501
check_for_updates:                       0
sorting_photos_col:                      taken_at
sorting_photos_order:                    ASC
sorting_albums_col:                      max_taken_at
sorting_albums_order:                    ASC
imagick:                                 1
skip_duplicates:                         0
small_max_width:                         0
small_max_height:                        360
medium_max_width:                        1920
medium_max_height:                       1080
lang:                                    en
image_overlay_type:                      desc
default_license:                         reserved
compression_quality:                     90
grants_full_photo_access:                1
delete_imported:                         0
mod_frame_enabled:                       1
mod_frame_refresh:                       30
thumb_2x:                                1
small_2x:                                1
medium_2x:                               1
landing_page_enable:                     0
force_migration_in_production:           0
search_public:                           0
hide_version_number:                     0
SL_enable:                               0
SL_for_admin:                            0
recent_age:                              1
grants_download:                         0
photos_wraparound:                       1
map_display:                             0
zip64:                                   1
map_display_public:                      0
map_provider:                            Wikimedia
force_32bit_ids:                         0
map_include_subalbums:                   0
update_check_every_days:                 3
has_exiftool:                            0
share_button_visible:                    0
import_via_symlink:                      0
has_ffmpeg:                              1
location_decoding:                       0
location_decoding_timeout:               30
location_show:                           1
location_show_public:                    0
rss_enable:                              0
rss_recent_days:                         7
rss_max_items:                           100
prefer_available_xmp_metadata:           0
editor_enabled:                          1
lossless_optimization:                   0
swipe_tolerance_x:                       150
swipe_tolerance_y:                       250
local_takestamp_video_formats:           .avi|.mov
log_max_num_line:                        1000
unlock_password_photos_with_url_param:   0
nsfw_visible:                            1
nsfw_blur:                               0
nsfw_warning:                            0
nsfw_warning_admin:                      0
nsfw_banner_override:                    
map_display_direction:                   1
album_subtitle_type:                     oldstyle
upload_processing_limit:                 4
new_photos_notification:                 0
legacy_id_redirection:                   1
zip_deflate_level:                       6
default_album_protection:                1
album_decoration:                        layers
album_decoration_orientation:            row
allow_username_change:                   1
auto_fix_orientation:                    1
use_job_queues:                          0
random_album_id:                         starred
use_last_modified_date_when_no_exif_date: 0
layout:                                  justified
date_format_photo_thumb:                 M j, Y, g:i:s A e
date_format_photo_overlay:               M j, Y, g:i:s A e
date_format_sidebar_uploaded:            M j, Y, g:i:s A e
date_format_sidebar_taken_at:            M j, Y, g:i:s A e
date_format_hero_min_max:                F Y
date_format_hero_created_at:             M j, Y, g:i:s A T
date_format_album_thumb:                 M Y
upload_chunk_size:                       0
nsfw_banner_blur_backdrop:               0
search_pagination_limit:                 1000
search_minimum_length_required:          4
photo_layout_justified_row_height:       320
photo_layout_masonry_column_width:       300
photo_layout_grid_column_width:          250
photo_layout_square_column_width:        200
photo_layout_gap:                        12
display_thumb_album_overlay:             always
display_thumb_photo_overlay:             hover
default_album_thumb_aspect_ratio:        1/1
use_album_compact_header:                0
login_button_position:                   left
back_button_enabled:                     0
back_button_text:                        Return to Home
current_job_processing_visible:          1
SA_random_thumbs:                        0
job_processing_queue_visible:            1
login_required:                          0
enable_unsorted:                         1
enable_starred:                          1
enable_recent:                           1
enable_on_this_day:                      1
login_required_root_only:                1

(I'm aware of the permissions issue but I don't think it's related. Lychee and Nextcloud have different ideas on what the permissions should be…)

Browser & System [REQUIRED]

Firefox 129.0 on Fedora 40

Please confirm (incomplete submissions will not be addressed)

• I have provided easy and step-by-step instructions to reproduce the bug.
• I understand my bug report will be removed if I haven't met the criteria above.

[d7415]

If set to "Public", the "Unsorted" album is visible without logging in, but appears empty ("Nothing to see here").

IIRC we still only expose "public" photos in the smart albums. I accept that would make a public unsorted album rather pointless.

Furthermore (more problematically from my POV), if I add a tag to an image in the Unsorted album and then create a public tag album for that tag, the image does not appear in the tag album.

The simplest workaround - create an album, make it public, put the photos in it.

master (024b8c2) -- Up to date (-4.2966181251265E-6 years ago).

This is very strange

(I'm aware of the permissions issue but I don't think it's related. Lychee and Nextcloud have different ideas on what the permissions should be…)

Nextcloud is very wrong here, but if it works then it's probably close enough.

[ildyria]

I'm back from vacations.

After further thought, I do agree with @jeanas that while there is nothing wrong with the current behaviour, it is indeed counter intuitive.
I will see what I can do to get this fixed, but that one is a slightly trickier.
In Unsorted as opposed to starred or recent, the pictures do not have an albums which determines their visibility. This makes the point of having the Unsorted smart album public a bit useless.

[ildyria]

Fixed in version 6.