Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures/encryption #138

Open
sp5wwp opened this issue Jun 23, 2024 · 3 comments
Open

Signatures/encryption #138

sp5wwp opened this issue Jun 23, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sp5wwp
Copy link
Member

sp5wwp commented Jun 23, 2024

  1. Expand the definition of the encryption subtype subfield of TYPE with AES key length indication.
  2. Add definitions for ECDSA signed streams.
@sp5wwp sp5wwp added the enhancement New feature or request label Jun 23, 2024
@sp5wwp sp5wwp self-assigned this Jun 23, 2024
@lwvmobile
Copy link

Something I was considering on that, is if we use the following setup for AES, it'll let us use the crypt code we've got currently and also allow compatibility to m17-tools which still uses the hard coded 128 keylen value, since that signals enc_subtype as 0 on AES, and is also the same progression of key len values that scrambler mode uses.

subtype 0 for AES 128;
subtype 1 for AES 192;
subtype 2 for AES 256;

@sp5wwp
Copy link
Member Author

sp5wwp commented Jun 23, 2024

Agreed! The enum in the code needs to be changed to start with 0.

@sp5wwp
Copy link
Member Author

sp5wwp commented Jun 23, 2024

AES subtypes added to the spec doc in dce7f5e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants