Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDAnalysis develop incompatible with numpy 2.0 #9

Closed
lilyminium opened this issue Jun 22, 2024 · 3 comments
Closed

MDAnalysis develop incompatible with numpy 2.0 #9

lilyminium opened this issue Jun 22, 2024 · 3 comments

Comments

@lilyminium
Copy link
Member

Related to MDAnalysis/cookiecutter-mdakit#129 -- perhaps we should be pinning numpy here for now?

Retriggering last week's CI yields failures for micromamba as well, so this may go beyond pip: https://github.com/MDAnalysis/install-mdanalysis/actions/runs/9531795135/job/26546804394

@lilyminium lilyminium mentioned this issue Jun 22, 2024
@IAlibay
Copy link
Member

IAlibay commented Jun 22, 2024

Assuming CI passes on latest changes here: MDAnalysis/mdanalysis#4620 (review)

The best approach is to fix the wheel building for MDA imho. This will avoid potential dependency clashes and/or further issues if you happen to pick up numpy before or after this action.

so this may go beyond pip

From a brief look, this is still pip related - the problem, as I see it, is that we're building MDA with a non 2.0 version but when picking up dependnecies (during the latter half of the pip install) it just picks up a newer version of numpy (because it can).

@IAlibay
Copy link
Member

IAlibay commented Jun 22, 2024

Ok I re-ran the last cron CI job and things seem to be good now: https://github.com/MDAnalysis/install-mdanalysis/actions/runs/9531795135

Are you happy with this solution @lilyminium ?

@lilyminium
Copy link
Member Author

Yes that's perfect, thanks for the fix @IAlibay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants