Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect coloring of mixed commit status #32

Open
jschwab opened this issue Apr 24, 2021 · 2 comments
Open

Incorrect coloring of mixed commit status #32

jschwab opened this issue Apr 24, 2021 · 2 comments

Comments

@jschwab
Copy link
Contributor

jschwab commented Apr 24, 2021

When one or more tests is a unanimous failure, a commit should be colored 'red' for failed. Mixed yellow color should be reserved for cases where there are no unanimous failures.

screenshot-on-2021-04-24-at-10:14:26

@wmwolf
Copy link
Member

wmwolf commented Apr 25, 2021

I made the choice to prioritize mixed results since they are more anomalous than across-the-board failures. Perhaps in the era of some computers running fpe or optional tests, this muddies the waters since we'll have many more mixed results.

Adding indicators at the branch and commit level views for fpe and optional tests is midway down my to-do list, so that may help clarify the noise, but do we really want to make the mixed tests less prominent in favor of full-on failures (though both are countable from the badges on the right)?

@jschwab
Copy link
Contributor Author

jschwab commented Apr 25, 2021

At present, because of the aggregation with the optional and FPE tests, the full failures are "worse" (i.e., more likely to demand my attention) than the mixed tests. But I see your point that might not always be the case. Fine to punt on this issue for now until the filtering/indication of other test types get polished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants