From 411cafb6781d45828de7fde3e7cd8d09d7b07a10 Mon Sep 17 00:00:00 2001
From: Brian Ok <63064763+okBrian@users.noreply.github.com>
Date: Tue, 5 Nov 2024 11:12:12 -0800
Subject: [PATCH] Cleanliness CI Fix Error & Now Can't error outside of build
 (#691)

---
 .github/workflows/cleanliness.yml | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/cleanliness.yml b/.github/workflows/cleanliness.yml
index e13fa9811f..89e063dc6f 100644
--- a/.github/workflows/cleanliness.yml
+++ b/.github/workflows/cleanliness.yml
@@ -34,35 +34,40 @@ jobs:
                 sed -i '/\/master\//d' master.txt
             
             - name: Unused Variables Diff
+              continue-on-error: true
               run: |
                 grep -F 'Wunused-variable' master.txt > mUnused.txt
                 grep -F 'Wunused-variable' pr.txt > prUnused.txt
-                diff prUnused.txt mUnused.txt || true
+                diff prUnused.txt mUnused.txt
             
             - name: Unused Dummy Arguments Diff
+              continue-on-error: true
               run: |
-                grep -F 'Wunused-dummy-argument' pr.txt > prDummy.txt
+                grep -F 'Wunused-dummy-argument' pr.txt > prDummy.txt 
                 grep -F 'Wunused-dummy-argument' master.txt > mDummy.txt
-                diff prDummy.txt mDummy.txt || true
+                diff prDummy.txt mDummy.txt
 
             - name: Unused Value Diff
+              continue-on-error: true
               run: |
                 grep -F 'Wunused-value' pr.txt > prUnused_val.txt
                 grep -F 'Wunused-value' master.txt > mUnused_val.txt
-                diff prUnused_val.txt mUnused_val.txt || true
+                diff prUnused_val.txt mUnused_val.txt
 
             - name: Maybe Uninitialized Variables Diff
+              continue-on-error: true
               run: |
                 grep -F 'Wmaybe-uninitialized' pr.txt > prMaybe.txt
                 grep -F 'Wmaybe-uninitialized' master.txt > mMaybe.txt
-                diff prMaybe.txt mMaybe.txt || true
+                diff prMaybe.txt mMaybe.txt
 
 
             - name: Everything Diff
+              continue-on-error: true
               run: |
-                grep '\-W' pr.txt > pr_every.txt 
+                grep '\-W' pr.txt > pr_every.txt
                 grep '\-W' master.txt > m_every.txt
-                diff pr_every.txt m_every.txt || true
+                diff pr_every.txt m_every.txt
 
             - name: List of Warnings
               run: |
@@ -70,6 +75,7 @@ jobs:
                 
 
             - name: Summary
+              continue-on-error: true
               run: |  
                 pr_variable=$(grep -c -F 'Wunused-variable' pr.txt)
                 pr_argument=$(grep -c -F 'Wunused-dummy-argument' pr.txt)
@@ -100,6 +106,5 @@ jobs:
               if: env.pr_everything > env.master_everything 
               run: |
                 echo "Difference between warning count in PR is greater than in master."
-                exit 1