Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code formatting to Python files? (at least examples/case.py?) #608

Closed
sbryngelson opened this issue Sep 5, 2024 · 0 comments · Fixed by #777
Closed

Add code formatting to Python files? (at least examples/case.py?) #608

sbryngelson opened this issue Sep 5, 2024 · 0 comments · Fixed by #777
Labels
question Further information is requested

Comments

@sbryngelson
Copy link
Member

It seems like some of our examples case.py files have strange formatting. This is probably, in part, a space/tab issue, though it is also inconsistent across different examples. This could easily be fixed by enforcing some sort of formatting for all Python files, or at least ones in examples/.

Black would do the trick (I tried it locally, and it looks consistent and "normal"). This could be integrated into CI just as ./mfc.sh lint (or perhaps as part of ./mfc.sh format).

@sbryngelson sbryngelson added the question Further information is requested label Sep 5, 2024
@sbryngelson sbryngelson linked a pull request Dec 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

Successfully merging a pull request may close this issue.

1 participant