-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DrawEM distribution package friendly #33
Comments
Just looked at the CMakeLists.txt. For what it's worth @soundray, you can at least use an existing ITK installation to build the N4 binary included in Draw-EM to save some build time. But of course I see the issue of having a duplicate |
Thanks Andreas. The background to this is that I have suggested inclusion of DrawEM in the NixOS package of MIRTK. Heads up to @lheckemann who maintains it. |
I see, thanks for this additional info. Sounds good to me. Regarding N4, I think ANTs only contains a program called More generally, I wonder about a few challenges for creating a distribution package for Draw-EM at the moment:
|
On an additional note, MIRTK extension packages such as Draw-EM can be build out of MIRTK source tree. Meaning, one can first build and install MIRTK with |
Regarding N4: how is DrawEM's N4 materially different from ANTs's? Does it even need to exist? Data dependencies: yes, the data dependencies issue is the next one I ran into — I think the ideal solution here in principle would be for cmake to allow "substituting" ExternalProject sources. That way, no additional work would be necessary on the DrawEM side (and this problem would be solved for all uses of ExternalProject). Out-of-source-tree build: I didn't realise this! That sounds like a much better solution than bundling everything in with mirtk itself. |
Rolf suggested in the MIRTK chat to enable use of an already existing N4 installation instead of building ITK from scratch. This should be easy to facilitate with a change of the CMakeLists.txt and would shorten build time.
The text was updated successfully, but these errors were encountered: