Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make callouts in the app more like Apple Maps' callouts #828

Open
2 tasks
justinanderson opened this issue Feb 5, 2015 · 2 comments
Open
2 tasks

Make callouts in the app more like Apple Maps' callouts #828

justinanderson opened this issue Feb 5, 2015 · 2 comments
Assignees
Milestone

Comments

@justinanderson
Copy link
Contributor

  • Support arrows on the left/right.
  • Support animating from one size and arrow position to another. Apple Maps on iPad does this.
@justinanderson justinanderson added this to the 4.0.2 milestone Feb 5, 2015
@loganwright loganwright self-assigned this Feb 9, 2015
@loganwright loganwright mentioned this issue Feb 12, 2015
2 tasks
@loganwright
Copy link
Contributor

@justinanderson - I tackled a lot of the popover stuff in the latest PR, I'm waiting for Ross to dig in to the specifics so that there's a second set of eyes making sure everything is readable and well organized.

Once you take a look, all of the drawing parameters should be easy to adjust, ie: arrow size, positioning, rounding, etc. I think this implementation cleans up a lot of the problems associated w/ SMCallout and is much more reliable with custom content views. Any features you're missing shouldn't be hard to add at this point.

I do have some questions about the animation. I was looking at Apple's implementation, and it seems to have a very specific set of events. The popover is always arrow down w/ text, subtitle, disclosure, and occasionally a left side image. This then animates to a very specific view controller that is always positioned left or right. I'm having a hard time thinking of a way to generalize this behavior to create a 'drop in' solution for this. Do you have any specific examples in the app that you'd like to see animated? I think this would be easier for me to implement a specific circumstance than something more general.

@justinanderson
Copy link
Contributor Author

@rosslebeau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants