Separate dining hall status from meal hours on iPad Dining

[justinanderson]

Continuation of conversation in #832.

iPad Dining currently looks like this, with dining hall names, hours, and whether the hall is open or closed all on one line. On iPhones, the meaning of the open/closed status is clearer both because of its visual separation from the meal's hours and because it's more specifically worded.

If we use that same string on iPads (e.g. "Opens at 5:30pm", "Open until 11am") instead of "Open" and "Closed", it should hopefully be clearer it's talking about the state of the dining hall and not the state of whichever meal the user is looking at. Here that is mocked up looking at lunch at while breakfast is still going at Maseeh, and here it is mocked up looking at dinner at that same time.

Don't take the spacing in the mockups to be gospel. Use whatever feels right.

[transitmark]

@justinanderson

Are these the appropriate labels for a previous day? "Closed for the day" ?

[justinanderson]

@Smartcop Those aren't the correct messages, but that's because it's showing info for the wrong day.

On the iPhone version, the message shown right now at 2:45 PM on Thursday March 12th for Maseeh is "Open until 3PM" no matter which day or meal I look at. On a build of the latest iPad code, that's only true if I look at meals happening on Thursday March 12th. When I look at Tuesday like your screenshot shows, the message changes to "Closed for the day". Similarly, when I look at Saturday it says "Opens at 10AM".

The message next to each dining hall on iPads should be the same as that message on iPhones — the state of the dining hall at the moment I'm looking at it, regardless of what meal of which day is currently being viewed. In this case that's "Open until 3PM".

Though there's also a bug going on there where it thinks all of the dining halls are closed for the day on Tuesday. All halls are open this week, and their info screen shows hours for every day of the week, so there's some bad logic in there somewhere.