-
Notifications
You must be signed in to change notification settings - Fork 66
Description
Hi all,
While testing DeepLenseSim end-to-end on Microsoft Windows 10 Pro, I noticed the current installation workflow is not fully reproducible due to missing dependencies and version mismatches.
Environment tested
- OS: Microsoft Windows 10 Pro
- Python: 3.11 (fresh venv)
What happens
Even after installing the repo, running the simulation scripts fails unless additional dependencies are installed manually.
1) Missing dependencies during runtime
Example errors observed during execution:
ModuleNotFoundError: No module named 'matplotlib'ModuleNotFoundError: No module named 'mcfit'
These packages are required by the scripts/pyHalo stack, but they are not installed automatically.
2) Version mismatch between pyHalo and lenstronomy
The README suggests:
lenstronomy==1.9.2
However, with current pyHalo (1.4.3) I encountered:
ModuleNotFoundError: No module named 'lenstronomy.LensModel.Profiles.pseudo_double_powerlaw'
which indicates pyHalo expects a newer compatible lenstronomy version.
Suggested improvement
Instead of adding a new requirements file, it may be better to update setup.py to include the required dependencies via install_requires (and optionally specify compatible version ranges).
This would make pip install -e . or pip install . reliably install everything needed to run the scripts.
It may also help to clarify supported Python versions (Python 3.10/3.11 worked reliably; Python 3.14 caused dependency build/wheel issues on Windows).
I’m happy to submit a PR updating setup.py dependencies if that’s helpful.
Note: I tested using the latest commits from mwt5345/DeepLenseSim#1 (PR branch), since the fixes are not merged into main yet.
Thanks...!