Group 1 Wed Sept 27th checkin #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added some basic attributes with potential functionality for a_star_search - Added attributes to decribe a specific type of agent
- Added some basic attributes with potential functionality for a_star_search - Added attributes to decribe a specific type of agent
Bringing branch up to date
Descriptions of current Agents implemented
Updated README and file deletion
Kanakmk
approved these changes
Sep 28, 2023
Added A* agent
…endent of location outside of user-control (I hope ;-;)
FergusonAJ
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Overall the changes look good. This PR adds A* pathfinding and an agent that uses it to move between multiple waypoints.
Two things we should change before merging:
- Switch the
.hfiles to.hppto keep things consistent - Similarly, changing
shortest_pathto be more consistent with the rest of the methods. Maybe something likeGetShortestPathorFindShortestPath?
source/Agents/AStarAgent.h
Outdated
There was a problem hiding this comment.
We should figure out what we want to put in the comment block at the top of each file eventually.
… be more uniform and easy to follow
FergusonAJ
requested changes
Oct 10, 2023
source/Agents/AgentLibary.hpp
Outdated
There was a problem hiding this comment.
The include of WorldBase is unnecessary and creates a circular include. This prevents the code from compiling on my machine. We should remove it.
Fix documentation error for PR 21
mercere99
reviewed
Oct 11, 2023
source/Agents/AStarAgent.hpp
Outdated
| // If the last step failed, or we need a new path the then regenerate the path | ||
| if (action_result == 0 || path.empty() || current_move_num > recalculate_after_x_turns) | ||
| { | ||
| path = world->ShortestPath(GetPosition(), goal_position); |
There was a problem hiding this comment.
Needs to know which agent is asking for the shortest path.
Adding PathAgent, support for running Catch2 tests with CMake
Moved GetShortestPath to AgentLib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the first external agent of group one. It tracks a path using A* to a given coordinate.
auto my_agent = dynamic_cast<cse491::walle::matt_k_first_agent *>(agent); my_agent->set_word(&world); my_agent->set_goal_position(cse491::GridPosition(1, 8)); my_agent->SetPosition(3, 1);Will create an agent that goes from position (3,1) to (1,8) While avoiding walls and other un-walkable areas defined by the world.
Future changes: