From 28d79cbd961cea4d2be504b1d2c3fea045ce5cc6 Mon Sep 17 00:00:00 2001 From: Ivan Gabriele Date: Wed, 28 Feb 2024 07:21:43 +0100 Subject: [PATCH] Ensure artifact download comes from the same commit sha in application workflows --- .github/workflows/application_deployment.yml | 5 +++-- .github/workflows/application_e2e_tests.yml | 10 ++++++---- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/application_deployment.yml b/.github/workflows/application_deployment.yml index 59a008dc7e..3455739016 100644 --- a/.github/workflows/application_deployment.yml +++ b/.github/workflows/application_deployment.yml @@ -40,6 +40,7 @@ jobs: - name: Download image uses: ishworkh/container-image-artifact-download@v1.0.0 with: + commit_sha: ${{ github.event.workflow_run.head_commit.id }} image: monitorfish-app:${{ env.VERSION }} token: ${{ secrets.GITHUB_TOKEN }} workflow: "Application Build" @@ -53,6 +54,6 @@ jobs: - uses: LouisBrunner/checks-action@v2.0.0 if: ${{ always() }} with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Application Deployment conclusion: ${{ job.status }} + name: Application Deployment + token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/application_e2e_tests.yml b/.github/workflows/application_e2e_tests.yml index be39f096ea..1fd20d88f9 100644 --- a/.github/workflows/application_e2e_tests.yml +++ b/.github/workflows/application_e2e_tests.yml @@ -45,6 +45,7 @@ jobs: - name: Download image uses: ishworkh/container-image-artifact-download@v1.0.0 with: + commit_sha: ${{ github.event.workflow_run.head_commit.id }} image: monitorfish-app:${{ env.VERSION }} token: ${{ secrets.GITHUB_TOKEN }} workflow: "Application Build" @@ -89,9 +90,9 @@ jobs: - uses: LouisBrunner/checks-action@v2.0.0 if: ${{ always() }} with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Application Cypress E2E tests conclusion: ${{ job.status }} + name: Application Cypress E2E tests + token: ${{ secrets.GITHUB_TOKEN }} e2e_multi_windows_test: name: Run E2E multi windows tests @@ -115,6 +116,7 @@ jobs: - name: Download image uses: ishworkh/container-image-artifact-download@v1.0.0 with: + commit_sha: ${{ github.event.workflow_run.head_commit.id }} image: monitorfish-app:${{ env.VERSION }} token: ${{ secrets.GITHUB_TOKEN }} workflow: "Application Build" @@ -147,6 +149,6 @@ jobs: - uses: LouisBrunner/checks-action@v2.0.0 if: ${{ always() }} with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Application Puppeteer E2E tests conclusion: ${{ job.status }} + name: Application Puppeteer E2E tests + token: ${{ secrets.GITHUB_TOKEN }}