Remove the "num" dependency.

This required a small change in the code that should be functionally
exactly the same. Tests pass, seems good.

The reason for removing this is to stop dependencies from mwalib
depending on a specific, new version of "num". Reducing compile times is
always good, too.

Author: cjordan

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "mwalib"
-version = "0.9.3"
+version = "0.9.4"
 homepage = "https://github.com/MWATelescope/mwalib"
 repository = "https://github.com/MWATelescope/mwalib"
 readme = "README.md"
@@ -34,9 +34,8 @@ fitsio-sys = "^0"  # fitsio also uses fitsio-sys so ensure we both use the same
 lazy_static = "1.4.*"
 libc = "0.2.*"
 log = "0.4.*"
-num = "0.4"
-num-derive = "0.3"
-num-traits = "0.2"
+num-derive = "0.3.*"
+num-traits = "0.2.*"
 rayon = ">=1.3,<1.6" # Allow downstream users to select the rayon version to use.
 regex = "1.5.*"
 thiserror = "1.0.*"

src/metafits_context/mod.rs

@@ -632,7 +632,7 @@ impl MetafitsContext {
 
         let geometric_delays_applied: GeometricDelaysApplied =
             match get_optional_fits_key!(&mut metafits_fptr, &metafits_hdu, "GEODEL")? {
-                Some(g) => match num::FromPrimitive::from_i32(g) {
+                Some(g) => match num_traits::FromPrimitive::from_i32(g) {
                     Some(gda) => gda,
                     None => {
                         return Err(MwalibError::Parse {

src/metafits_context/test.rs

@@ -544,18 +544,18 @@ fn test_geometric_delays_applied_enum() {
     assert!(GeometricDelaysApplied::from_str("Az/El Tracking").is_ok());
     assert!(GeometricDelaysApplied::from_str("something invalid").is_err());
 
-    let i32_none: GeometricDelaysApplied = num::FromPrimitive::from_i32(0).unwrap();
-    let i32_zen: GeometricDelaysApplied = num::FromPrimitive::from_i32(1).unwrap();
-    let i32_tile: GeometricDelaysApplied = num::FromPrimitive::from_i32(2).unwrap();
-    let i32_azel: GeometricDelaysApplied = num::FromPrimitive::from_i32(3).unwrap();
+    let i32_none: GeometricDelaysApplied = num_traits::FromPrimitive::from_i32(0).unwrap();
+    let i32_zen: GeometricDelaysApplied = num_traits::FromPrimitive::from_i32(1).unwrap();
+    let i32_tile: GeometricDelaysApplied = num_traits::FromPrimitive::from_i32(2).unwrap();
+    let i32_azel: GeometricDelaysApplied = num_traits::FromPrimitive::from_i32(3).unwrap();
 
     assert_eq!(i32_none, GeometricDelaysApplied::No);
     assert_eq!(i32_zen, GeometricDelaysApplied::Zenith);
     assert_eq!(i32_tile, GeometricDelaysApplied::TilePointing);
     assert_eq!(i32_azel, GeometricDelaysApplied::AzElTracking);
 
     let geo_delay: GeometricDelaysApplied = match Some(1) {
-        Some(g) => num::FromPrimitive::from_i32(g).unwrap(),
+        Some(g) => num_traits::FromPrimitive::from_i32(g).unwrap(),
         None => GeometricDelaysApplied::No,
     };
     assert_eq!(geo_delay, GeometricDelaysApplied::Zenith);