imprv: Improved the error handling & removed boilerplate code

Author: reasje

lib/features/dapps/subfeatures/open_dapp/open_dapp_presenter.dart

@@ -32,6 +32,7 @@ class OpenDAppPresenter extends CompletePresenter<OpenDAppState> {
   late final _accountUseCase = ref.read(accountUseCaseProvider);
   late final _authUseCase = ref.read(authUseCaseProvider);
   late final _customTokensUseCase = ref.read(customTokensUseCaseProvider);
+  late final _errorUseCase = ref.read(errorUseCaseProvider);
 
   @override
   void initState() {
@@ -232,48 +233,27 @@ class OpenDAppPresenter extends CompletePresenter<OpenDAppState> {
       }
     } catch (e, s) {
       cancel.call();
-      if (e is RPCError) {
-        handleError(e.message);
-      }
-      addError(e, s);
+      callErrorHandler(e, s);
     } finally {
       loading = false;
     }
   }
 
-  void handleError(String message) {
-    final isBottomSheetShown = checkBalanceErrors(message);
-
-    // String errorMessage = message;
-    // errorMessage = changeErrorMessage(errorMessage);
-    // addError(errorMessage);
-  }
-
-  bool checkBalanceErrors(String message) {
-    bool isShown = false;
-    for (String error in Config.fundErrors) {
-      if (message.contains(error)) {
-        final network = state.network!;
-        final walletAddress = state.account!.address;
-        showReceiveBottomSheet(
-          context!,
-          walletAddress,
-          network.chainId,
-          network.symbol,
-          () {
-            navigator!.pop();
-            final chainId = state.network!.chainId;
-            final l3BridgeUri = Uri.parse(Urls.networkL3Bridge(chainId));
-            state.webviewController!
-                .loadUrl(urlRequest: URLRequest(url: l3BridgeUri));
-          },
-          _chainConfigurationUseCase.launchUrlInPlatformDefault,
-        );
-        isShown = true;
-        break;
-      }
+  void callErrorHandler(dynamic e, StackTrace s) {
+    final isHandled = _errorUseCase.handleError(
+      context!,
+      e,
+      onL3Tap: () {
+        navigator!.pop();
+        final chainId = state.network!.chainId;
+        final l3BridgeUri = Uri.parse(Urls.networkL3Bridge(chainId));
+        state.webviewController!
+            .loadUrl(urlRequest: URLRequest(url: l3BridgeUri));
+      },
+    );
+    if (!isHandled) {
+      addError(e, s);
     }
-    return isShown;
   }
 
   Future<bool?> addEthereumChain(

lib/features/portfolio/presentation/portfolio_page.dart

@@ -96,7 +96,7 @@ class PortfolioPage extends HookConsumerWidget {
                               .iconButtonBackgroundActive,
                           color: ColorsTheme.of(context).iconButtonInvertActive,
                           icon: MxcIcons.receive,
-                          onTap: () => presenter.showReceiveBottomSheet(),
+                          onTap: () => presenter.showReceiveSheet(),
                           titleStyle: FontTheme.of(context).subtitle1.primary(),
                           iconSize: 24,
                           filled: false,

lib/features/portfolio/presentation/portfolio_page_presenter.dart

@@ -100,30 +100,18 @@ class PortfolioPresenter extends CompletePresenter<PortfolioState> {
     }
   }
 
-  void showReceiveBottomSheet() {
+  void showReceiveSheet() {
     final walletAddress = state.walletAddress!;
-    if (Config.isMxcChains(state.network!.chainId)) {
-      showWalletAddressDialogMXCChains(
-          context: context!,
-          walletAddress: walletAddress,
-          onL3Tap: () {
-            final chainId = state.network!.chainId;
-            final l3BridgeUri = Urls.networkL3Bridge(chainId);
-            Navigator.of(context!).push(route.featureDialog(
-              maintainState: false,
-              OpenAppPage(
-                url: l3BridgeUri,
-              ),
-            ));
-          },
-          launchUrlInPlatformDefault:
-              _chainConfigurationUseCase.launchUrlInPlatformDefault);
-    } else {
-      final networkSymbol = state.network!.symbol;
-      showWalletAddressDialogOtherChains(
-          context: context!,
-          walletAddress: walletAddress,
-          networkSymbol: networkSymbol);
-    }
+    final chainId = state.network!.chainId;
+    final networkSymbol = state.network!.symbol;
+    showReceiveBottomSheet(context!, walletAddress, chainId, networkSymbol, () {
+      final l3BridgeUri = Urls.networkL3Bridge(chainId);
+      Navigator.of(context!).push(route.featureDialog(
+        maintainState: false,
+        OpenAppPage(
+          url: l3BridgeUri,
+        ),
+      ));
+    }, _chainConfigurationUseCase.launchUrlInPlatformDefault, false);
   }
 }

lib/features/portfolio/subfeatures/token/send_token/send_crypto/send_crypto_presenter.dart

@@ -52,6 +52,7 @@ class SendCryptoPresenter extends CompletePresenter<SendCryptoState> {
   late final accountInfo = ref.read(appNavBarContainer.state);
   late final _chainConfigurationUseCase =
       ref.read(chainConfigurationUseCaseProvider);
+  late final _errorUseCase = ref.read(errorUseCaseProvider);
 
   late final TextEditingController amountController = TextEditingController();
   late final TextEditingController recipientController =
@@ -220,9 +221,7 @@ class SendCryptoPresenter extends CompletePresenter<SendCryptoState> {
 
       return gasFee;
     } catch (e, s) {
-      if (e is RPCError) {
-        handleError(e.message);
-      }
+      callErrorHandler(e, s);
     } finally {
       loading = false;
     }
@@ -264,55 +263,31 @@ class SendCryptoPresenter extends CompletePresenter<SendCryptoState> {
 
       return res;
     } catch (e, s) {
-      if (e is RPCError) {
-        if (BottomFlowDialog.maybeOf(context!) != null) {
-          BottomFlowDialog.of(context!).close();
-        }
-        handleError(e.message);
+      if (BottomFlowDialog.maybeOf(context!) != null) {
+        BottomFlowDialog.of(context!).close();
       }
+      callErrorHandler(e, s);
     } finally {
       loading = false;
     }
   }
 
-  void handleError(String message) {
-    final isBottomSheetShown = checkBalanceErrors(message);
-
-    // String errorMessage = message;
-    // errorMessage = changeErrorMessage(errorMessage);
-    // addError(errorMessage);
-  }
-
-  bool checkBalanceErrors(String message) {
-    bool isShown = false;
-    for (String error in Config.fundErrors) {
-      if (message.contains(error)) {
-        final network = state.network!;
-        final walletAddress = state.account!.address;
-        final chainId = network.chainId;
-        showReceiveBottomSheet(
-          context!,
-          walletAddress,
-          chainId,
-          network.symbol,
-          () {
-            final l3BridgeUri = Urls.networkL3Bridge(chainId);
-            Navigator.of(context!).push(route.featureDialog(
-              maintainState: false,
-              OpenAppPage(
-                url: l3BridgeUri,
-              ),
-            ));
-          },
-          _chainConfigurationUseCase.launchUrlInPlatformDefault,
-        );
-        isShown = true;
-        break;
-      }
+  void callErrorHandler(dynamic e, StackTrace s) {
+    final isHandled = _errorUseCase.handleError(context!, e, onL3Tap: () {
+      final chainId = state.network!.chainId;
+      final l3BridgeUri = Urls.networkL3Bridge(chainId);
+      Navigator.of(context!).push(route.featureDialog(
+        maintainState: false,
+        OpenAppPage(
+          url: l3BridgeUri,
+        ),
+      ));
+    });
+    if (!isHandled) {
+      addError(e, s);
     }
-    return isShown;
   }
-  
+
   @override
   Future<void> dispose() async {
     super.dispose();