From 2d2256a25400295fa5476626d40ef634f2ce10b8 Mon Sep 17 00:00:00 2001 From: Lee Bradley Date: Tue, 12 Feb 2019 12:52:34 +0000 Subject: [PATCH] Remove custom dependency for asset-admin Also fix `Image::Quality` to match signature on parent --- composer.json | 6 +----- src/Model/Image.php | 7 ++++++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/composer.json b/composer.json index 4c4d3ea..5f4f32b 100644 --- a/composer.json +++ b/composer.json @@ -13,14 +13,10 @@ "homepage": "https://www.example.com" } ], - "repositories": [{ - "type": "vcs", - "url": "git@github.com:oilee80/silverstripe-asset-admin.git" - }], "require": { "cloudinary/cloudinary_php": "dev-master", "php": ">=7.0.0", - "silverstripe/asset-admin": "1.1.0-rc3" + "silverstripe/asset-admin": "^1.1" }, "autoload": { "psr-4": { diff --git a/src/Model/Image.php b/src/Model/Image.php index f7040f4..ebed841 100644 --- a/src/Model/Image.php +++ b/src/Model/Image.php @@ -144,7 +144,12 @@ public function Crop(string $crop = 'fill') * @param int $quality * @return CachedImage */ - public function Quality(string $quality = 'auto') + public function Quality($quality) + { + return $quality ? $this->setQuality($quality) : $this->setQuality(); + } + + public function setQuality(string $quality= 'auto') { return $this->Transform([ 'quality' => $quality ]); }