Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover/Click transaction style exception. #170

Closed
3 tasks
FrederLu opened this issue May 30, 2023 · 14 comments
Closed
3 tasks

Hover/Click transaction style exception. #170

FrederLu opened this issue May 30, 2023 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@FrederLu
Copy link

FrederLu commented May 30, 2023

  • 1、When the mouse hovers over a single transaction, it needs to have a UI draft style, and at the same time set the mouse to a clickable hand style.
image
  • 2、The style is abnormal after the mouse clicks a single transaction.
image
  • 3、There is now an issue with transaction detail styling (day/night) after double click. The following operation is changed to click after the mouse hovers (refer to the first point above).
2023-05-30.11.33.47-2.mov
@FrederLu FrederLu added the bug Something isn't working label May 30, 2023
@Danie0918 Danie0918 assigned devchenyan and alexsupa597 and unassigned Danie0918 Jun 5, 2023
@devchenyan devchenyan assigned Danie0918 and unassigned devchenyan Jun 6, 2023
@Danie0918 Danie0918 removed their assignment Jun 12, 2023
@alexsupa597
Copy link

@Danie0918 Please confirm whether the details popup of "Recent Income and Expenses" on the homepage and the transaction history details should be the same content or not. In our old application, they look the same. It's just that the content of this popup seems to have not been processed by the new UI design.

If so:
1、Should this popup be processed into a page like the transaction history details or kept as a popup?
2、If it is processed into a page like the transaction history details, there is currently no return function. Only the breadcrumb at the top is provided. Do we need to consider adding a return function or just provide the breadcrumb to route to the transaction history?

@Danie0918
Copy link
Contributor

Please confirm whether the details popup of "Recent Income and Expenses" on the homepage and the transaction history details should be the same content or not. In our old application, they look the same. It's just that the content of this popup seems to have not been processed by the new UI design.

If so: 1、Should this popup be processed into a page like the transaction history details or kept as a popup? 2、If it is processed into a page like the transaction history details, there is currently no return function. Only the breadcrumb at the top is provided. Do we need to consider adding a return function or just provide the breadcrumb to route to the transaction history?

Yes, the popup should be treated as a page like the transaction history details.

Regarding the return function here is really needed, only the breadcrumbs are not obvious enough. @Kirl70
image

@Kirl70
Copy link

Kirl70 commented Jun 15, 2023

The corresponding pages have been added and the return style has been adjusted. The following pages, which previously had breadcrumbs, have also been modified accordingly: Transaction History / Transaction Details Nervos DAO / Transaction Details Asset Account / Transaction Details
https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=17798%3A39356&t=FjVJk3xEm1BBsbff-1
image

In the previous version, I didn't notice that the recent transactions list was clickable because there were no indications on the page. We should change the mouse to a clickable gesture when the mouse is moved to the list. What do you think? @Danie0918
image

@Danie0918
Copy link
Contributor

Danie0918 commented Jun 15, 2023

In the previous version, I didn't notice that the recent transactions list was clickable because there were no indications on the page. We should change the mouse to a clickable gesture when the mouse is moved to the list. What do you think?

Ok, this change to a hand gesture is reasonable. @JeffreyMa597

@alexsupa597
Copy link

alexsupa597 commented Jun 16, 2023

In the previous version, I didn't notice that the recent transactions list was clickable because there were no indications on the page. We should change the mouse to a clickable gesture when the mouse is moved to the list. What do you think?

Ok, this change to a hand gesture is reasonable. @JeffreyMa597

@Danie0918 Okay, based on my understanding, the original interaction of double-clicking to open details will be deprecated and replaced by single-clicking to open details. Am I right?

@Danie0918
Copy link
Contributor

Okay, based on my understanding, the original interaction of double-clicking to open details will be deprecated and replaced by single-clicking to open details. Am I right?

Yes.

@alexsupa597
Copy link

PR: nervosnetwork/neuron#2725

@FrederLu
Copy link
Author

PR: nervosnetwork/neuron#2725

When viewing transaction details on the 'Overview' page, the options in the left column should remain the same.
image
image


When the mouse hovers over the data, the mouse has a style, but the hovered data still lacks the style selected by the UI (the background color of the data changes).
image
image

@Danie0918 Danie0918 assigned FrederLu and unassigned FrederLu and alexsupa597 Jun 26, 2023
@FrederLu
Copy link
Author

FrederLu commented Jul 4, 2023

PR: nervosnetwork/neuron#2725

When viewing transaction details on the 'Overview' page, the options in the left column should remain the same. image image

Now the first point in the remark information still exists, and when you click on the detailed information on the overview page, the left column will still jump to display the transaction details in the transaction history.

@alexsupa597
Copy link

alexsupa597 commented Jul 4, 2023

Now the first point in the remark information still exists, and when you click on the detailed information on the overview page, the left column will still jump to display the transaction details in the transaction history.

After clicking the transaction items, turning to the transaction detail page is expected, not the transaction history, when you are on the overview page.
#170 (comment)

@FrederLu
Copy link
Author

FrederLu commented Jul 4, 2023

Now the first point in the remark information still exists, and when you click on the detailed information on the overview page, the left column will still jump to display the transaction details in the transaction history.

After clicking the transaction items, turning to the transaction detail page is expected, not the transaction history, when you are on the overview page. #170 (comment)

@Danie0918 @Kirl70
Now when viewing the transaction details on the overview page, Transaction History will be selected in the left column. This is based on the logic modification of the details displayed in the pop-up window before, but through the current UI design, it is found that Overview should be selected in the left column at this time. Is this according to The latest UI design?
If it need to follow the latest UI design, this part needs to be modified by @JeffreyMa597 .
image

2023-07-04.20.28.41.mov

@Danie0918
Copy link
Contributor

@Danie0918 @Kirl70 Now when viewing the transaction details on the overview page, Transaction History will be selected in the left column. This is based on the logic modification of the details displayed in the pop-up window before, but through the current UI design, it is found that Overview should be selected in the left column at this time. Is this according to The latest UI design? If it need to follow the latest UI design, this part needs to be modified by @JeffreyMa597 . image

The transaction history under Overview should remain under the Overview menu.

@alexsupa597
Copy link

The transaction history under Overview should remain under the Overview menu.

Got it. Updated.

@FrederLu
Copy link
Author

FrederLu commented Jul 5, 2023

Verified.

@Keith-CY Keith-CY closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

6 participants