Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: inconsitency in phantom model image and load #234

Closed
ThomasCeulemans opened this issue Oct 20, 2023 · 0 comments · Fixed by #235
Closed

Docs: inconsitency in phantom model image and load #234

ThomasCeulemans opened this issue Oct 20, 2023 · 0 comments · Fixed by #235
Assignees
@ThomasCeulemans
Labels
documentation Improvements or additions to documentation

Comments

@ThomasCeulemans
Copy link
Collaborator

ThomasCeulemans commented Oct 20, 2023 •
edited
Loading

In the docs, we now use plons to import phantom models since #228; however it seems that we imported a slightly different time snapshot of the same hydrodynamics model. Thus I need to update/rerun the jupyter notebooks such that the image is once again consistent.
@ThomasCeulemans ThomasCeulemans added the documentation Improvements or additions to documentation label Oct 20, 2023
@ThomasCeulemans ThomasCeulemans self-assigned this Oct 20, 2023
@ThomasCeulemans ThomasCeulemans linked a pull request Oct 20, 2023 that will close this issue
Jupyter notebooks for phantom model updated. #235
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasCeulemans ThomasCeulemans

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jupyter notebooks for phantom model updated. Magritte-code/Magritte
1 participant
@ThomasCeulemans